From abb54f7832682bad1545b307a545a7ba977ef209 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Fri, 12 Jan 2024 15:41:14 +0100 Subject: [PATCH] build: Don't add the `neon` feature for arm and aarch64 (#31075) This was enabled to allow using the simd / std::simd / packed-simd crate in the glyph cache [1][2]. Support for simd in the gfx crate was removed though [3], so this flag is not really doing anything -- and the Android build is currently broken. Plus, it's unclear what target features we can enable using stable Rust. We can explore adding neon support when Android is working again. This is part of a long-term effort to remove build complication and make it so that `cargo build` is equivalent to `./mach build`. 1. https://github.com/servo/servo/pull/10916 2. https://github.com/servo/servo/pull/10900 3. https://github.com/servo/servo/pull/24304 --- python/servo/command_base.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/python/servo/command_base.py b/python/servo/command_base.py index 4fb4078f9fd..e4e1642e9ec 100644 --- a/python/servo/command_base.py +++ b/python/servo/command_base.py @@ -527,12 +527,6 @@ class CommandBase(object): if not (self.config["build"]["ccache"] == ""): env['CCACHE'] = self.config["build"]["ccache"] - # Ensure Rust uses hard floats and SIMD on ARM devices - if self.cross_compile_target and ( - self.cross_compile_target.startswith('arm') - or self.cross_compile_target.startswith('aarch64')): - env['RUSTFLAGS'] += " -C target-feature=+neon" - env["CARGO_TARGET_DIR"] = servo.util.get_target_dir() # Work around https://github.com/servo/servo/issues/24446