Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove erroneous check from CopyTexImage2D

Browse source 
The internal format of the bound texture doesn't matter, what matters is
which components can be found in the framebuffer.
This commit is contained in:
Anthony Ramine 2018-09-13 15:16:29 +02:00
parent 9db1a5cd0b
commit ac822ee2fc
1 changed files with 0 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/webglrenderingcontext.rs
View file

@ -1752,22 +1752,6 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
Err(_) => return,
};
let image_info = texture.image_info_for_target(&target, level);
// The color buffer components can be dropped during the conversion to
// the internal_format, but new components cannot be added.
//
// Note that this only applies if we're copying to an already
// initialized texture.
//
// GL_INVALID_OPERATION is generated if the color buffer cannot be
// converted to the internal_format.
if let Some(old_internal_format) = image_info.internal_format() {
if old_internal_format.components() > internal_format.components() {
return self.webgl_error(InvalidOperation);
}
}
// NB: TexImage2D depth is always equal to 1
handle_potential_webgl_error!(self, texture.initialize(target,
width as u32,