From dc4709dfde1e27c6b7e885bd752c2eee7d899148 Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Mon, 14 Jul 2014 17:07:24 -0700 Subject: [PATCH 1/2] Fix comment about "impossible" render messages. These messages are not impossible; they happen when a page contains iframes. --- src/components/compositing/constellation.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/compositing/constellation.rs b/src/components/compositing/constellation.rs index a243bf4f3ee..529ae8a92ea 100644 --- a/src/components/compositing/constellation.rs +++ b/src/components/compositing/constellation.rs @@ -723,8 +723,7 @@ impl Constellation { for current_frame in self.current_frame().iter() { // Messages originating in the current frame are not navigations; - // TODO(tkuehn): In fact, this kind of message might be provably - // impossible to occur. + // they may come from a page load in a sub-frame. if current_frame.contains(pipeline_id) { for frame in current_frame.iter() { frame.pipeline.grant_paint_permission(); From 7b79cb4092d9e80b7f8a19c72faf35f5fd51eafc Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Mon, 14 Jul 2014 17:30:00 -0700 Subject: [PATCH 2/2] Comment spelling fix --- src/components/compositing/constellation.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/compositing/constellation.rs b/src/components/compositing/constellation.rs index 529ae8a92ea..4d55b25f4f4 100644 --- a/src/components/compositing/constellation.rs +++ b/src/components/compositing/constellation.rs @@ -723,7 +723,7 @@ impl Constellation { for current_frame in self.current_frame().iter() { // Messages originating in the current frame are not navigations; - // they may come from a page load in a sub-frame. + // they may come from a page load in a subframe. if current_frame.contains(pipeline_id) { for frame in current_frame.iter() { frame.pipeline.grant_paint_permission();