Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove the implementation OptionalSettable for Option<JS<T>> to remove needless '&mut self'.

Browse source
This commit is contained in:
Tetsuharu OHZEKI 2014-05-31 23:40:24 +09:00
parent a0a0e07f71
commit ad22b29b2d
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/components/script/dom/bindings/js.rs
View file

@ -260,20 +260,12 @@ impl<T: Reflectable> Assignable<T> for Temporary<T> {
/// Assign an optional rootable value (either of JS<T> or Temporary<T>) to an optional /// Assign an optional rootable value (either of JS<T> or Temporary<T>) to an optional
/// field of a DOM type (ie. Option<JS<T>>) /// field of a DOM type (ie. Option<JS<T>>)
pub trait OptionalSettable<T> { pub trait OptionalSettable<T> {
fn assign(&mut self, val: Option<T>); fn assign(&self, val: Option<T>);
}
impl<T: Assignable<U>, U: Reflectable> OptionalSettable<T> for Option<JS<U>> {
fn assign(&mut self, val: Option<T>) {
*self = val.map(|val| unsafe { val.get_js() });
}
} }
impl<T: Assignable<U>, U: Reflectable> OptionalSettable<T> for Cell<Option<JS<U>>> { impl<T: Assignable<U>, U: Reflectable> OptionalSettable<T> for Cell<Option<JS<U>>> {
fn assign(&mut self, val: Option<T>) { fn assign(&self, val: Option<T>) {
let mut item = self.get(); self.set(val.map(|val| unsafe { val.get_js() }));
item.assign(val);
self.set(item);
} }
} }