Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25801 - pylbrecht:arc.refactor, r=jdm

Browse source 
Refactor CanvasRenderingContext2D.arc() and .ellipse()

<!-- Please describe your changes on the following line: -->
Refactor `arc()` and `ellipse()` to make use of `lyon_geom::Arc` for approximating an arc with quadratic bezier curves.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-02-26 09:04:08 -05:00 • committed by GitHub
commit ad9bfc2a62
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 55 additions and 151 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/metadata/2dcontext/line-styles/2d.line.cap.round.html.ini
View file

@ -1,4 +0,0 @@
[2d.line.cap.round.html]
[lineCap 'round' is rendered correctly]
expected: FAIL

4
tests/wpt/metadata/2dcontext/path-objects/2d.path.arc.twopie.1.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.1.html]
[arc() draws nothing when end = start + 2pi-e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/2dcontext/path-objects/2d.path.arc.twopie.3.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.3.html]
[arc() draws a full circle when end = start + 2pi+e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/2dcontext/path-objects/2d.path.arcTo.scale.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.scale.html]
[arcTo scales the curve, not just the control points]
expected: FAIL

5
tests/wpt/metadata/2dcontext/path-objects/2d.path.arcTo.shape.curve2.html.ini
View file

@ -1,5 +0,0 @@
[2d.path.arcTo.shape.curve2.html]
type: testharness
[arcTo() curves in the right kind of shape]
expected: FAIL

4
tests/wpt/metadata/2dcontext/path-objects/2d.path.arcTo.transformation.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.transformation.html]
[arcTo joins up to the last subpath point correctly]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/line-styles/2d.line.cap.round.html.ini
View file

@ -1,4 +0,0 @@
[2d.line.cap.round.html]
[lineCap 'round' is rendered correctly]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/line-styles/2d.line.cap.round.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.line.cap.round.worker.html]
[lineCap 'round' is rendered correctly]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arc.twopie.1.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.1.html]
[arc() draws nothing when end = start + 2pi-e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arc.twopie.1.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.1.worker.html]
[arc() draws nothing when end = start + 2pi-e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arc.twopie.3.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.3.html]
[arc() draws a full circle when end = start + 2pi+e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arc.twopie.3.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.path.arc.twopie.3.worker.html]
[arc() draws a full circle when end = start + 2pi+e and anticlockwise]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.scale.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.scale.html]
[arcTo scales the curve, not just the control points]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.scale.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.scale.worker.html]
[arcTo scales the curve, not just the control points]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.shape.curve2.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.shape.curve2.html]
[arcTo() curves in the right kind of shape]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.shape.curve2.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.shape.curve2.worker.html]
[arcTo() curves in the right kind of shape]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.transformation.html.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.transformation.html]
[arcTo joins up to the last subpath point correctly]
expected: FAIL

4
tests/wpt/metadata/offscreen-canvas/path-objects/2d.path.arcTo.transformation.worker.js.ini
View file

@ -1,4 +0,0 @@
[2d.path.arcTo.transformation.worker.html]
[arcTo joins up to the last subpath point correctly]
expected: FAIL