Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-24 15:50:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Prevent multiple notifications for image dimensions (#36600)

Browse source 
Added a simple check to only perform metadata extraction and listener
notification when we haven't already processed the metadata for an image

Testing: Existing tests should cover if we break decoding image metadata
complete.
Fixes: #36502

---------

Signed-off-by: Barigbue <barigbuenbira@gmail.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Barigbue Nbira 2025-04-18 21:01:26 +01:00 • committed by GitHub
parent 46247a7621
commit add8c51f47
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

20
components/net/image_cache.rs
View file

@ -608,16 +608,18 @@ impl ImageCache for ImageCacheImpl {
pending_load.bytes.extend_from_slice(&data); pending_load.bytes.extend_from_slice(&data);
//jmr0 TODO: possibly move to another task? //jmr0 TODO: possibly move to another task?
let mut reader = std::io::Cursor::new(pending_load.bytes.as_slice()); if pending_load.metadata.is_none() {
if let Ok(info) = imsz_from_reader(&mut reader) { let mut reader = std::io::Cursor::new(pending_load.bytes.as_slice());
let img_metadata = ImageMetadata { if let Ok(info) = imsz_from_reader(&mut reader) {
width: info.width as u32, let img_metadata = ImageMetadata {
height: info.height as u32, width: info.width as u32,
}; height: info.height as u32,
for listener in &pending_load.listeners { };
listener.respond(ImageResponse::MetadataLoaded(img_metadata.clone())); for listener in &pending_load.listeners {
listener.respond(ImageResponse::MetadataLoaded(img_metadata.clone()));
}
pending_load.metadata = Some(img_metadata);
} }
pending_load.metadata = Some(img_metadata);
} }
}, },
(FetchResponseMsg::ProcessResponseEOF(_, result), key) => { (FetchResponseMsg::ProcessResponseEOF(_, result), key) => {