mirror of
https://github.com/servo/servo.git
synced 2025-08-02 04:00:32 +01:00
Prevent multiple notifications for image dimensions (#36600)
Added a simple check to only perform metadata extraction and listener notification when we haven't already processed the metadata for an image Testing: Existing tests should cover if we break decoding image metadata complete. Fixes: #36502 --------- Signed-off-by: Barigbue <barigbuenbira@gmail.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
46247a7621
commit
add8c51f47
1 changed files with 11 additions and 9 deletions
|
@ -608,6 +608,7 @@ impl ImageCache for ImageCacheImpl {
|
|||
pending_load.bytes.extend_from_slice(&data);
|
||||
|
||||
//jmr0 TODO: possibly move to another task?
|
||||
if pending_load.metadata.is_none() {
|
||||
let mut reader = std::io::Cursor::new(pending_load.bytes.as_slice());
|
||||
if let Ok(info) = imsz_from_reader(&mut reader) {
|
||||
let img_metadata = ImageMetadata {
|
||||
|
@ -619,6 +620,7 @@ impl ImageCache for ImageCacheImpl {
|
|||
}
|
||||
pending_load.metadata = Some(img_metadata);
|
||||
}
|
||||
}
|
||||
},
|
||||
(FetchResponseMsg::ProcessResponseEOF(_, result), key) => {
|
||||
debug!("Received EOF for {:?}", key);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue