mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
Auto merge of #23654 - julientregoat:issue-23645, r=jdm
Fix panic when running test-background-fetch-permission.html <!-- Please describe your changes on the following line: --> * Propagate `Error::JSFailed` in `Permissions::create_descriptor` * In `Error::to_jsval`, only check if a JS exception is not pending if `self` is not `Error::JSFailed` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23645 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a test runner, so by nature if the test runs the test runner is also working as expected. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23654) <!-- Reviewable:end -->
This commit is contained in:
commit
af295bcefe
4 changed files with 13 additions and 10 deletions
|
@ -1,6 +1,10 @@
|
|||
[interfaces.any.html]
|
||||
expected: CRASH
|
||||
[Permissions interface: operation query(object)]
|
||||
expected: FAIL
|
||||
|
||||
[Permissions interface: calling query(object) on navigator.permissions with too few arguments must throw TypeError]
|
||||
expected: FAIL
|
||||
|
||||
|
||||
[interfaces.any.worker.html]
|
||||
expected: CRASH
|
||||
|
||||
expected: CRASH
|
|
@ -1,5 +1,3 @@
|
|||
[test-background-fetch-permission.html]
|
||||
expected: CRASH
|
||||
[Test Background Fetch Permission.]
|
||||
expected: FAIL
|
||||
|
||||
expected: FAIL
|
Loading…
Add table
Add a link
Reference in a new issue