From af8f35f5ef51e9743274f149900f0c9c80ca5288 Mon Sep 17 00:00:00 2001 From: Ville Lindholm Date: Sun, 8 Dec 2024 18:50:28 +0200 Subject: [PATCH] traverse Shadow DOM boundaries when determining element lang (#34529) Signed-off-by: Ville Lindholm --- components/script/dom/element.rs | 2 +- .../lang-attribute-shadow.window.js.ini | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 tests/wpt/meta/html/dom/elements/global-attributes/lang-attribute-shadow.window.js.ini diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index 594c63bbab6..f28070a7bf7 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -4146,7 +4146,7 @@ impl Element { // https://html.spec.whatwg.org/multipage/#language pub fn get_lang(&self) -> String { self.upcast::() - .inclusive_ancestors(ShadowIncluding::No) + .inclusive_ancestors(ShadowIncluding::Yes) .filter_map(|node| { node.downcast::().and_then(|el| { el.get_attribute(&ns!(xml), &local_name!("lang")) diff --git a/tests/wpt/meta/html/dom/elements/global-attributes/lang-attribute-shadow.window.js.ini b/tests/wpt/meta/html/dom/elements/global-attributes/lang-attribute-shadow.window.js.ini deleted file mode 100644 index 69d3423ce87..00000000000 --- a/tests/wpt/meta/html/dom/elements/global-attributes/lang-attribute-shadow.window.js.ini +++ /dev/null @@ -1,9 +0,0 @@ -[lang-attribute-shadow.window.html] - [lang on slot inherits from shadow host] - expected: FAIL - - [lang only on host] - expected: FAIL - - [lang on host and slotted element] - expected: FAIL