mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #7559 - ddrmanxbxfr:RFC-0344-Work, r=nox
Remove 'get_*' on getters as per RFC 0344 on canevas, compositing, devtools, gfx, layout, net, profile, servo and webdriver_server Hi guys, I just gave a big pass of RFC-0344 as per issue #6224 . Pretty much renamed all the get_* fn that were used to fetch values. I hope I didn't rename too much. As said in the issue discussion, I didn't touch at the scripts folder so we keep the unsafe ones pretty explicit. I've ran the whole pass of test, everything seems to be still working right :). Please give feedback on this PR. Thanks for looking into it. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7559) <!-- Reviewable:end -->
This commit is contained in:
commit
b05f4aa3aa
30 changed files with 167 additions and 168 deletions
|
@ -187,8 +187,8 @@ impl Browser {
|
|||
self.compositor.pinch_zoom_level()
|
||||
}
|
||||
|
||||
pub fn get_title_for_main_frame(&self) {
|
||||
self.compositor.get_title_for_main_frame()
|
||||
pub fn request_title_for_main_frame(&self) {
|
||||
self.compositor.title_for_main_frame()
|
||||
}
|
||||
|
||||
pub fn shutdown(mut self) {
|
||||
|
|
|
@ -42,7 +42,7 @@ fn main() {
|
|||
env_logger::init().unwrap();
|
||||
|
||||
// Parse the command line options and store them globally
|
||||
opts::from_cmdline_args(&*get_args());
|
||||
opts::from_cmdline_args(&*args());
|
||||
|
||||
setup_logging();
|
||||
|
||||
|
@ -138,7 +138,7 @@ fn setup_logging() {
|
|||
}
|
||||
|
||||
#[cfg(target_os = "android")]
|
||||
fn get_args() -> Vec<String> {
|
||||
fn args() -> Vec<String> {
|
||||
vec![
|
||||
"servo".to_owned(),
|
||||
"http://en.wikipedia.org/wiki/Rust".to_owned()
|
||||
|
@ -146,7 +146,7 @@ fn get_args() -> Vec<String> {
|
|||
}
|
||||
|
||||
#[cfg(not(target_os = "android"))]
|
||||
fn get_args() -> Vec<String> {
|
||||
fn args() -> Vec<String> {
|
||||
use std::env;
|
||||
env::args().collect()
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue