Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-16 19:05:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #7559 - ddrmanxbxfr:RFC-0344-Work, r=nox

Browse source 
Remove 'get_*' on getters as per RFC 0344 on canevas, compositing, devtools, gfx, layout, net, profile, servo and webdriver_server

Hi guys,

I just gave a big pass of RFC-0344 as per issue #6224 .

Pretty much renamed all the get_* fn that were used to fetch values. 

I hope I didn't rename too much. 

As said in the issue discussion, I didn't touch at the scripts folder so we keep the unsafe ones pretty explicit.

I've ran the whole pass of test, everything seems to be still working right :).

Please give feedback on this PR.

Thanks for looking into it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7559)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-09-12 18:29:56 -06:00
commit b05f4aa3aa
30 changed files with 167 additions and 168 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ports/cef/browser.rs
View file

@ -40,10 +40,10 @@ impl ServoBrowser {
}
}
pub fn get_title_for_main_frame(&self) {
pub fn request_title_for_main_frame(&self) {
match *self {
ServoBrowser::OnScreen(ref browser) => browser.get_title_for_main_frame(),
ServoBrowser::OffScreen(ref browser) => browser.get_title_for_main_frame(),
ServoBrowser::OnScreen(ref browser) => browser.request_title_for_main_frame(),
ServoBrowser::OffScreen(ref browser) => browser.request_title_for_main_frame(),
ServoBrowser::Invalid => {}
}
}
@ -165,7 +165,7 @@ impl ServoCefBrowser {
pub trait ServoCefBrowserExtensions {
fn init(&self, window_info: &cef_window_info_t);
fn send_window_event(&self, event: WindowEvent);
fn get_title_for_main_frame(&self);
fn request_title_for_main_frame(&self);
fn pinch_zoom_level(&self) -> f32;
}
@ -207,8 +207,8 @@ impl ServoCefBrowserExtensions for CefBrowser {
}
}
fn get_title_for_main_frame(&self) {
self.downcast().servo_browser.borrow().get_title_for_main_frame()
fn request_title_for_main_frame(&self) {
self.downcast().servo_browser.borrow().request_title_for_main_frame()
}
fn pinch_zoom_level(&self) -> f32 {

2
ports/cef/frame.rs
View file

@ -46,7 +46,7 @@ full_cef_class_impl! {
fn get_text(&this, visitor: *mut cef_string_visitor_t [CefStringVisitor],) -> () {{
let this = this.downcast();
*this.title_visitor.borrow_mut() = Some(visitor);
this.browser.borrow().as_ref().unwrap().get_title_for_main_frame();
this.browser.borrow().as_ref().unwrap().request_title_for_main_frame();
}}
}
}