Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix Clippy warning: remove unneeded late initialization of string (#33840)

Browse source 
* Fix Clippy warning: remove unneeded late initialization of string

Signed-off-by: L Ashwin B <lashwinib@gmail.com>

* Fixed the comments placement

Signed-off-by: L Ashwin B <lashwinib@gmail.com>

---------

Signed-off-by: L Ashwin B <lashwinib@gmail.com>
This commit is contained in:
chickenleaf 2024-10-15 11:39:26 +05:30 • committed by GitHub
parent 46d6c0c883
commit b088a8b8f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/script/dom/dommatrixreadonly.rs
View file

@ -822,10 +822,6 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
return Err(error::Error::InvalidState); return Err(error::Error::InvalidState);
} }
// Step 2. Let string be the empty string.
let string;
// Step 3. If is 2D is true, then:
let cx = GlobalScope::get_cx(); let cx = GlobalScope::get_cx();
let to_string = |f: f64| { let to_string = |f: f64| {
let value = jsval::DoubleValue(f); let value = jsval::DoubleValue(f);
@ -839,7 +835,10 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
) )
} }
}; };
if self.is2D() {
// Step 2. Let string be the empty string.
// Step 3. If is 2D is true, then:
let string = if self.is2D() {
// Step 3.1 Append "matrix(" to string. // Step 3.1 Append "matrix(" to string.
// Step 3.2 Append ! ToString(m11 element) to string. // Step 3.2 Append ! ToString(m11 element) to string.
// Step 3.3 Append ", " to string. // Step 3.3 Append ", " to string.
@ -853,7 +852,7 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
// Step 3.11 Append ", " to string. // Step 3.11 Append ", " to string.
// Step 3.12 Append ! ToString(m42 element) to string. // Step 3.12 Append ! ToString(m42 element) to string.
// Step 3.13 Append ")" to string. // Step 3.13 Append ")" to string.
string = format!( format!(
"matrix({}, {}, {}, {}, {}, {})", "matrix({}, {}, {}, {}, {}, {})",
to_string(mat.m11), to_string(mat.m11),
to_string(mat.m12), to_string(mat.m12),
@ -862,7 +861,7 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
to_string(mat.m41), to_string(mat.m41),
to_string(mat.m42) to_string(mat.m42)
) )
.into(); .into()
} }
// Step 4. Otherwise: // Step 4. Otherwise:
else { else {
@ -894,7 +893,7 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
// NOTE: The spec is wrong and missing the m3* elements. // NOTE: The spec is wrong and missing the m3* elements.
// (https://github.com/w3c/fxtf-drafts/issues/574) // (https://github.com/w3c/fxtf-drafts/issues/574)
string = format!( format!(
"matrix3d({}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {})", "matrix3d({}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {})",
to_string(mat.m11), to_string(mat.m11),
to_string(mat.m12), to_string(mat.m12),
@ -913,8 +912,8 @@ impl DOMMatrixReadOnlyMethods for DOMMatrixReadOnly {
to_string(mat.m43), to_string(mat.m43),
to_string(mat.m44) to_string(mat.m44)
) )
.into(); .into()
} };
Ok(string) Ok(string)
} }