Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Some CanGc Fixes (#33865)

Browse source 
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com>
This commit is contained in:
komuhangi 2024-10-16 18:14:28 +03:00 • committed by GitHub
parent 2b9527262c
commit b0a33d6b02
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/bindings/codegen/Bindings.conf
View file

@ -235,6 +235,7 @@ DOMInterfaces = {
'URL': { 'URL': {
'weakReferenceable': True, 'weakReferenceable': True,
'canGc': ['Parse'],
}, },
'VRDisplay': { 'VRDisplay': {

3
components/script/dom/url.rs
View file

@ -162,6 +162,7 @@ impl URLMethods for URL {
global: &GlobalScope, global: &GlobalScope,
url: USVString, url: USVString,
base: Option<USVString>, base: Option<USVString>,
can_gc: CanGc,
) -> Option<DomRoot<URL>> { ) -> Option<DomRoot<URL>> {
// Step 1: Let parsedURL be the result of running the API URL parser on url with base, // Step 1: Let parsedURL be the result of running the API URL parser on url with base,
// if given. // if given.
@ -176,7 +177,7 @@ impl URLMethods for URL {
// These steps are all handled while mapping the Result to an Option<ServoUrl>. // These steps are all handled while mapping the Result to an Option<ServoUrl>.
// Regarding initialization, the same condition should apply here as stated in the comments // Regarding initialization, the same condition should apply here as stated in the comments
// in Self::Constructor above - construct it on-demand inside `URL::SearchParams`. // in Self::Constructor above - construct it on-demand inside `URL::SearchParams`.
Some(URL::new(global, None, parsed_url.ok()?, CanGc::note())) Some(URL::new(global, None, parsed_url.ok()?, can_gc))
} }
/// <https://w3c.github.io/FileAPI/#dfn-createObjectURL> /// <https://w3c.github.io/FileAPI/#dfn-createObjectURL>