Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make sure reftests aren't passing because nothing == nothing

Browse source 
In the test harness, assert that the two images aren't all white.

Fixes #3481
This commit is contained in:
Gilles Leblanc 2014-10-10 19:21:10 -04:00
parent be6cde9322
commit b15860e531
7 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/ref/background_none_a.html
View file

@ -15,7 +15,7 @@
</style>
</head>
<body>
<div id=a></div>
<div id=a>Background: none test</div>
</body>
</html>

2
tests/ref/background_none_b.html
View file

@ -10,7 +10,7 @@
</style>
</head>
<body>
<div id=a></div>
<div id=a>Background: none test</div>
</body>
</html>

1
tests/ref/iframe/multiple_external.html
View file

@ -11,6 +11,7 @@
</style>
</head>
<body>
iframe test
<iframe sandbox="allow-scripts" src="multiple_external_child.html"> </iframe>
<iframe sandbox="allow-scripts" src="multiple_external_child.html"> </iframe>
</body>

1
tests/ref/iframe/multiple_external_ref.html
View file

@ -1,5 +1,6 @@
<!DOCTYPE html>
<html>
<body>
iframe test
</body>
</html>

1
tests/ref/img_dynamic_remove.html
View file

@ -1,4 +1,5 @@
<!doctype html>
Image dynamic remove
<img src=400x400_green.png>
<script>
document.getElementsByTagName("img")[0].removeAttribute("src");

1
tests/ref/img_dynamic_remove_ref.html
View file

@ -1,2 +1,3 @@
<!doctype html>
Image dynamic remove
<img>

7
tests/reftest.rs
View file

@ -259,6 +259,13 @@ fn check_reftest(reftest: Reftest) {
assert_eq!(left_width, right_width);
assert_eq!(left_height, right_height);
let left_all_white = left_bytes.iter().all(|&p| p == 255);
let right_all_white = right_bytes.iter().all(|&p| p == 255);
if left_all_white && right_all_white {
fail!("Both rendering are empty")
}
let pixels = left_bytes.iter().zip(right_bytes.iter()).map(|(&a, &b)| {
if a as i8 - b as i8 == 0 {
// White for correct