Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Radio button grouping is now case-sensitive

Browse source
This commit is contained in:
Patrick Shaughnessy 2019-12-31 17:57:59 -05:00
parent 90acd1adc3
commit b20881639e
2 changed files with 1 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/script/dom/htmlinputelement.rs
View file

@ -46,7 +46,6 @@ use crate::textinput::KeyReaction::{
}; };
use crate::textinput::Lines::Single; use crate::textinput::Lines::Single;
use crate::textinput::{Direction, SelectionDirection, TextInput, UTF16CodeUnits, UTF8Bytes}; use crate::textinput::{Direction, SelectionDirection, TextInput, UTF16CodeUnits, UTF8Bytes};
use caseless::compatibility_caseless_match_str;
use dom_struct::dom_struct; use dom_struct::dom_struct;
use embedder_traits::FilterPattern; use embedder_traits::FilterPattern;
use encoding_rs::Encoding; use encoding_rs::Encoding;
@ -917,7 +916,7 @@ fn in_same_group(
// TODO Both a and b are in the same home subtree. // TODO Both a and b are in the same home subtree.
other.form_owner().as_deref() == owner && other.form_owner().as_deref() == owner &&
match (other.radio_group_name(), group) { match (other.radio_group_name(), group) {
(Some(ref s1), Some(s2)) => compatibility_caseless_match_str(s1, s2) && s2 != &atom!(""), (Some(ref s1), Some(s2)) => s1 == s2 && s2 != &atom!(""),
_ => false _ => false
} }
} }

26
tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini
View file

@ -1,26 +0,0 @@
[radio-groupname-case.html]
type: testharness
[radio button group name = paSSfield-killroyß]
expected: FAIL
[Among names like sImPlE, everything must be checkable at the same time]
expected: FAIL
[Among names like paSSfield-killroyß, everything must be checkable at the same time]
expected: FAIL
[Among names like глупый, everything must be checkable at the same time]
expected: FAIL
[Among names like åωk, everything must be checkable at the same time]
expected: FAIL
[Among names like blah1, everything must be checkable at the same time]
expected: FAIL
[Among names like tÉdz5アパートFi, everything must be checkable at the same time]
expected: FAIL
[Among names like ΣΣ, everything must be checkable at the same time]
expected: FAIL