From b238eae66cdff14c5868290b69616ef39e1f15cb Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Sun, 24 Sep 2017 00:47:29 -0700 Subject: [PATCH] Add FIXME for font-size animated value --- components/style/values/computed/font.rs | 4 ++++ components/style/values/computed/length.rs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/components/style/values/computed/font.rs b/components/style/values/computed/font.rs index 8edca57bda9..6d0571b8c0c 100644 --- a/components/style/values/computed/font.rs +++ b/components/style/values/computed/font.rs @@ -76,6 +76,10 @@ impl ToCss for FontSize { } } +/// XXXManishearth it might be better to +/// animate this as computed, however this complicates +/// clamping and might not be the right thing to do. +/// We should figure it out. impl ToAnimatedValue for FontSize { type AnimatedValue = NonNegativeLength; diff --git a/components/style/values/computed/length.rs b/components/style/values/computed/length.rs index c6cea9429c8..ea55f8bd4e4 100644 --- a/components/style/values/computed/length.rs +++ b/components/style/values/computed/length.rs @@ -792,7 +792,7 @@ impl NonNegativeLength { } #[inline] - /// Ensures it is positive + /// Ensures it is non negative pub fn clamp(self) -> Self { if (self.0).0 < 0. { Self::zero()