Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-19 22:59:03 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement MicrotaskRunnable for DefaultTeeReadRequestMicrotask (#37404)

Browse source 
Implement `MicrotaskRunnable` for `DefaultTeeReadRequestMicrotask` to
run the microtask, instead of using its own ad-hoc mechanism via
`DefaultTeeReadRequestMicrotask::microtask_chunk_steps`.

Testing: No need for this refactoring.
Fixes: #37246

---------

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
This commit is contained in:
Kingsley Yung 2025-06-12 18:46:31 +08:00 • committed by GitHub
parent 41bed9840a
commit b28e796647
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/defaultteereadrequest.rs
View file

@ -6,7 +6,7 @@ use std::cell::Cell;
use std::rc::Rc; use std::rc::Rc;
use dom_struct::dom_struct; use dom_struct::dom_struct;
use js::jsapi::Heap; use js::jsapi::{Heap, JSAutoRealm};
use js::jsval::{JSVal, UndefinedValue}; use js::jsval::{JSVal, UndefinedValue};
use js::rust::HandleValue as SafeHandleValue; use js::rust::HandleValue as SafeHandleValue;
@ -20,7 +20,8 @@ use crate::dom::defaultteeunderlyingsource::DefaultTeeUnderlyingSource;
use crate::dom::globalscope::GlobalScope; use crate::dom::globalscope::GlobalScope;
use crate::dom::promise::Promise; use crate::dom::promise::Promise;
use crate::dom::readablestream::ReadableStream; use crate::dom::readablestream::ReadableStream;
use crate::microtask::Microtask; use crate::microtask::{Microtask, MicrotaskRunnable};
use crate::realms::enter_realm;
use crate::script_runtime::{CanGc, JSContext as SafeJSContext}; use crate::script_runtime::{CanGc, JSContext as SafeJSContext};
#[derive(JSTraceable, MallocSizeOf)] #[derive(JSTraceable, MallocSizeOf)]
@ -31,9 +32,14 @@ pub(crate) struct DefaultTeeReadRequestMicrotask {
tee_read_request: Dom<DefaultTeeReadRequest>, tee_read_request: Dom<DefaultTeeReadRequest>,
} }
impl DefaultTeeReadRequestMicrotask { impl MicrotaskRunnable for DefaultTeeReadRequestMicrotask {
pub(crate) fn microtask_chunk_steps(&self, cx: SafeJSContext, can_gc: CanGc) { fn handler(&self, can_gc: CanGc) {
self.tee_read_request.chunk_steps(cx, &self.chunk, can_gc) let cx = GlobalScope::get_cx();
self.tee_read_request.chunk_steps(cx, &self.chunk, can_gc);
}
fn enter_realm(&self) -> JSAutoRealm {
enter_realm(&*self.tee_read_request)
} }
} }

3
components/script/microtask.rs
View file

@ -147,7 +147,8 @@ impl MicrotaskQueue {
MutationObserver::notify_mutation_observers(can_gc); MutationObserver::notify_mutation_observers(can_gc);
}, },
Microtask::ReadableStreamTeeReadRequest(ref task) => { Microtask::ReadableStreamTeeReadRequest(ref task) => {
task.microtask_chunk_steps(cx, can_gc) let _realm = task.enter_realm();
task.handler(can_gc);
}, },
} }
} }