script: Fix code generation for named getters.

Fixes part of #18535
This commit is contained in:
Emilio Cobos Álvarez 2017-09-17 07:32:01 +02:00
parent 4b72eb7168
commit b29e56eefc
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
3 changed files with 68 additions and 6 deletions

View file

@ -4938,8 +4938,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
set += ("if RUST_JSID_IS_STRING(id) {\n" + set += ("if RUST_JSID_IS_STRING(id) {\n" +
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() + CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
" return (*opresult).succeed();\n" + " return (*opresult).succeed();\n" +
"} else {\n" +
" return false;\n" +
"}\n") "}\n")
else: else:
set += ("if RUST_JSID_IS_STRING(id) {\n" + set += ("if RUST_JSID_IS_STRING(id) {\n" +
@ -4948,7 +4946,7 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
" return (*opresult).failNoNamedSetter();\n" " return (*opresult).failNoNamedSetter();\n"
" }\n" " }\n"
"}\n") "}\n")
set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args) set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args)
return set return set
def definition_body(self): def definition_body(self):

View file

@ -1,6 +1,5 @@
[storage_setitem.html] [storage_setitem.html]
type: testharness type: testharness
expected: TIMEOUT
[localStorage[\] = "<22>"] [localStorage[\] = "<22>"]
expected: FAIL expected: FAIL
bug: https://github.com/servo/servo/issues/6564 bug: https://github.com/servo/servo/issues/6564
@ -14,6 +13,72 @@
bug: https://github.com/servo/servo/issues/6564 bug: https://github.com/servo/servo/issues/6564
[localStorage["0"\]] [localStorage["0"\]]
expected: TIMEOUT expected: FAIL
bug: https://github.com/servo/servo/issues/10686 bug: https://github.com/servo/servo/issues/10686
[localStorage["1"\]]
expected: FAIL
[localStorage["2"\]]
expected: FAIL
[localStorage["3"\]]
expected: FAIL
[localStorage["4"\]]
expected: FAIL
[localStorage["5"\]]
expected: FAIL
[localStorage["6"\]]
expected: FAIL
[localStorage["7"\]]
expected: FAIL
[localStorage["8"\]]
expected: FAIL
[localStorage["9"\]]
expected: FAIL
[sessionStorage[\] = "<22>"]
expected: FAIL
[sessionStorage[\] = "<22>a"]
expected: FAIL
[sessionStorage[\] = "a<>"]
expected: FAIL
[sessionStorage["0"\]]
expected: FAIL
[sessionStorage["1"\]]
expected: FAIL
[sessionStorage["2"\]]
expected: FAIL
[sessionStorage["3"\]]
expected: FAIL
[sessionStorage["4"\]]
expected: FAIL
[sessionStorage["5"\]]
expected: FAIL
[sessionStorage["6"\]]
expected: FAIL
[sessionStorage["7"\]]
expected: FAIL
[sessionStorage["8"\]]
expected: FAIL
[sessionStorage["9"\]]
expected: FAIL

View file

@ -5,4 +5,3 @@
[Untitled] [Untitled]
expected: FAIL expected: FAIL