Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Re-implement evaluate_key_path_on_value in IndexedDB (#38847)

Browse source 
The current implementation of evaluate_key_path_on_value was translated
from gecko, and it is incomplete. The unimplemented part occurs many
crashes in WPT tests.

This PR re-implements it according to the spec. It should eliminate many
crashed WPT tests, and increase the code readability.

Testing: Update WPT test expectation
Fixes: #38817 partially, and #25325

---------

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
This commit is contained in:
Kingsley Yung 2025-09-05 16:00:07 +08:00 • committed by GitHub
parent ebc1282c7a
commit b29eab0ffe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 694 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

31
tests/wpt/meta/IndexedDB/idbobjectstore_add.any.js.ini vendored
View file

@ -2,10 +2,37 @@
expected: ERROR
[idbobjectstore_add.any.worker.html]
expected: CRASH
[add() where an index has unique:true specified]
expected: FAIL
[add() autoIncrement and inline keys]
expected: FAIL
[add() autoIncrement and out-of-line keys]
expected: FAIL
[Object store has autoIncrement:true and the key path is an object attribute]
expected: FAIL
[add() a record where a value being indexed does not meet the constraints of a valid key]
expected: FAIL
[idbobjectstore_add.any.serviceworker.html]
expected: ERROR
[idbobjectstore_add.any.html]
expected: CRASH
[add() where an index has unique:true specified]
expected: FAIL
[add() autoIncrement and inline keys]
expected: FAIL
[add() autoIncrement and out-of-line keys]
expected: FAIL
[Object store has autoIncrement:true and the key path is an object attribute]
expected: FAIL
[add() a record where a value being indexed does not meet the constraints of a valid key]
expected: FAIL