Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Follow-up to work done in #4304.

Browse source 
all_elements should ignore root as well.
This commit is contained in:
Tomasz Kołodziejski 2014-12-12 10:39:21 -08:00
parent 5913ba983b
commit b30cdb8a5c
3 changed files with 4 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/htmlcollection.rs
View file

@ -62,7 +62,10 @@ impl HTMLCollection {
namespace_filter: Option<Namespace> namespace_filter: Option<Namespace>
} }
impl CollectionFilter for AllElementFilter { impl CollectionFilter for AllElementFilter {
fn filter(&self, elem: JSRef<Element>, _root: JSRef<Node>) -> bool { fn filter(&self, elem: JSRef<Element>, root: JSRef<Node>) -> bool {
if NodeCast::from_ref(elem) == root {
return false
}
match self.namespace_filter { match self.namespace_filter {
None => true, None => true,
Some(ref namespace) => *elem.namespace() == *namespace Some(ref namespace) => *elem.namespace() == *namespace

4
tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini
View file

@ -5,7 +5,3 @@
[hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames] [hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames]
expected: FAIL expected: FAIL
[getElementsByTagName(\'*\')]
expected: FAIL

7
tests/wpt/metadata/dom/nodes/Element-getElementsByTagNameNS.html.ini
View file

@ -1,7 +0,0 @@
[Element-getElementsByTagNameNS.html]
type: testharness
[getElementsByTagNameNS(\'http://www.w3.org/1999/xhtml\', \'*\')]
expected: FAIL
[getElementsByTagNameNS(\'*\', \'*\')]
expected: FAIL