mirror of
https://github.com/servo/servo.git
synced 2025-08-03 20:50:07 +01:00
Eliminate HAS_CHANGED in favor of explicit RestyleDamage.
This commit is contained in:
parent
f1043f6305
commit
b31ed2298c
5 changed files with 18 additions and 36 deletions
|
@ -118,16 +118,13 @@ impl<'lc, N> DomTraversalContext<N> for RecalcStyleAndConstructFlows<'lc>
|
|||
return false;
|
||||
}
|
||||
|
||||
// If this node has been marked as damaged in some way, we need to
|
||||
// traverse it for layout.
|
||||
if child.has_changed() {
|
||||
return true;
|
||||
}
|
||||
|
||||
match child.as_element() {
|
||||
Some(el) => el.styling_mode() != StylingMode::Stop,
|
||||
// Aside from the has_changed case above, we want to traverse non-element children
|
||||
// in two additional cases:
|
||||
// Elements should be traversed if they need styling or flow construction.
|
||||
Some(el) => el.styling_mode() != StylingMode::Stop ||
|
||||
el.as_node().to_threadsafe().restyle_damage() != RestyleDamage::empty(),
|
||||
|
||||
// Text nodes never need styling. However, there are two cases they may need
|
||||
// flow construction:
|
||||
// (1) They child doesn't yet have layout data (preorder traversal initializes it).
|
||||
// (2) The parent element has restyle damage (so the text flow also needs fixup).
|
||||
None => child.get_raw_data().is_none() ||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue