mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
Auto merge of #15690 - vwvww:issue_14898, r=Wafflespeanut
Add 'use statements with extraneous spaces' tidy check Add 'use statements with extraneous spaces' tidy check I added simple check routine for 'use statements with extraneous spaces' and codes that breaks the check routine in rust_tidy.rs. * Added a code that using 'use statements with extraneous spaces' code in rust_tidy.rs * Added assertion code in test_tidy.py. * check_rust function in tidy.py now recognizes the simple case in the 'use statements with extraneous spaces'. * Ran tidy check on rust code and modified a code(tests/unit/style/parsing/inherited_text.rs) that is not passing on this new tidy check. TODO: this code has to be refactored to support more general cases, such as tab or newline. - [X] `./mach build -d` does not report any errors - [X] ./mach test-tidy does not report any errors - [X] These changes fix #14898 (github issue number if applicable). - [X] These changes do not require tests because ./mach test-tidy itself is the test for the code. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15690) <!-- Reviewable:end -->
This commit is contained in:
commit
b34fdf6234
4 changed files with 8 additions and 1 deletions
|
@ -74,7 +74,7 @@ fn text_emphasis_style_longhand_should_parse_properly() {
|
|||
#[test]
|
||||
fn test_text_emphasis_position() {
|
||||
use style::properties::longhands::text_emphasis_position;
|
||||
use style::properties::longhands::text_emphasis_position::{HorizontalWritingModeValue, VerticalWritingModeValue };
|
||||
use style::properties::longhands::text_emphasis_position::{HorizontalWritingModeValue, VerticalWritingModeValue};
|
||||
use style::properties::longhands::text_emphasis_position::SpecifiedValue;
|
||||
|
||||
let over_right = parse_longhand!(text_emphasis_position, "over right");
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue