Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25633 - pshaughn:localnames, r=jdm

Browse source 
Remove unnecessary LocalName::from(constant) calls

Changing calls to LocalName::from with a constant argument to use the interned local name instead doesn't really save a meaningful amount of time (when it's not in a loop or on a critical path), but it's good for codebase consistency.
This commit is contained in:
bors-servo 2020-01-29 10:22:30 -05:00 • committed by GitHub
commit b3ac17b82f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/htmlimageelement.rs
View file

@ -1293,7 +1293,7 @@ impl HTMLImageElement {
.filter_map(DomRoot::downcast::<HTMLMapElement>) .filter_map(DomRoot::downcast::<HTMLMapElement>)
.find(|n| { .find(|n| {
n.upcast::<Element>() n.upcast::<Element>()
.get_string_attribute(&LocalName::from("name")) == .get_string_attribute(&local_name!("name")) ==
last last
}); });

4
components/script/dom/servoparser/prefetch.rs
View file

@ -128,7 +128,7 @@ impl TokenSink for PrefetchSink {
self.origin.clone(), self.origin.clone(),
self.pipeline_id, self.pipeline_id,
self.get_cors_settings(tag, local_name!("crossorigin")), self.get_cors_settings(tag, local_name!("crossorigin")),
self.get_referrer_policy(tag, LocalName::from("referrerpolicy")), self.get_referrer_policy(tag, local_name!("referrerpolicy")),
FromPictureOrSrcSet::No, FromPictureOrSrcSet::No,
); );
let _ = self let _ = self
@ -145,7 +145,7 @@ impl TokenSink for PrefetchSink {
let cors_setting = let cors_setting =
self.get_cors_settings(tag, local_name!("crossorigin")); self.get_cors_settings(tag, local_name!("crossorigin"));
let referrer_policy = let referrer_policy =
self.get_referrer_policy(tag, LocalName::from("referrerpolicy")); self.get_referrer_policy(tag, local_name!("referrerpolicy"));
let integrity_metadata = self let integrity_metadata = self
.get_attr(tag, local_name!("integrity")) .get_attr(tag, local_name!("integrity"))
.map(|attr| String::from(&attr.value)) .map(|attr| String::from(&attr.value))