Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove styles when link node is removed from document

Browse source
This commit is contained in:
Roman Zaynetdinov 2017-01-09 19:31:04 +02:00
parent 9760ea2953
commit b3ce08f1b5
5 changed files with 68 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/script/dom/htmllinkelement.rs
View file

@ -18,7 +18,7 @@ use dom::element::{AttributeMutation, Element, ElementCreator};
use dom::element::{cors_setting_for_element, reflect_cross_origin_attribute, set_cross_origin_attribute}; use dom::element::{cors_setting_for_element, reflect_cross_origin_attribute, set_cross_origin_attribute};
use dom::globalscope::GlobalScope; use dom::globalscope::GlobalScope;
use dom::htmlelement::HTMLElement; use dom::htmlelement::HTMLElement;
use dom::node::{Node, document_from_node, window_from_node}; use dom::node::{Node, UnbindContext, document_from_node, window_from_node};
use dom::stylesheet::StyleSheet as DOMStyleSheet; use dom::stylesheet::StyleSheet as DOMStyleSheet;
use dom::virtualmethods::VirtualMethods; use dom::virtualmethods::VirtualMethods;
use html5ever_atoms::LocalName; use html5ever_atoms::LocalName;
@ -213,6 +213,15 @@ impl VirtualMethods for HTMLLinkElement {
} }
} }
} }
fn unbind_from_tree(&self, context: &UnbindContext) {
if let Some(ref s) = self.super_type() {
s.unbind_from_tree(context);
}
let document = document_from_node(self);
document.invalidate_stylesheets();
}
} }

24
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -6462,6 +6462,18 @@
"url": "/_mozilla/mozilla/iframe/resize_after_load.html" "url": "/_mozilla/mozilla/iframe/resize_after_load.html"
} }
], ],
"mozilla/remove_link_styles.html": [
{
"path": "mozilla/remove_link_styles.html",
"references": [
[
"/_mozilla/mozilla/remove_link_styles_ref.html",
"=="
]
],
"url": "/_mozilla/mozilla/remove_link_styles.html"
}
],
"mozilla/reparse_style_elements.html": [ "mozilla/reparse_style_elements.html": [
{ {
"path": "mozilla/reparse_style_elements.html", "path": "mozilla/reparse_style_elements.html",
@ -21852,6 +21864,18 @@
"url": "/_mozilla/mozilla/iframe/resize_after_load.html" "url": "/_mozilla/mozilla/iframe/resize_after_load.html"
} }
], ],
"mozilla/remove_link_styles.html": [
{
"path": "mozilla/remove_link_styles.html",
"references": [
[
"/_mozilla/mozilla/remove_link_styles_ref.html",
"=="
]
],
"url": "/_mozilla/mozilla/remove_link_styles.html"
}
],
"mozilla/reparse_style_elements.html": [ "mozilla/reparse_style_elements.html": [
{ {
"path": "mozilla/reparse_style_elements.html", "path": "mozilla/reparse_style_elements.html",

4
tests/wpt/mozilla/tests/mozilla/remove_link_styles.css Normal file
View file

@ -0,0 +1,4 @@
body {
background-color: red;
color: white !important;
}

19
tests/wpt/mozilla/tests/mozilla/remove_link_styles.html Normal file
View file

@ -0,0 +1,19 @@
<!doctype html>
<meta charset="utf-8">
<title>Removing link tag should remove associated styles</title>
<link rel="stylesheet" type="text/css" href="remove_link_styles.css">
<link rel="match" href="remove_link_styles_ref.html">
<body>
<style>
body {
color: green;
}
</style>
This text should be green and the background should not be red.
<script>
var l = document.querySelector('link[rel="stylesheet"]');
l.parentNode.removeChild(l);
</script>
</body>

11
tests/wpt/mozilla/tests/mozilla/remove_link_styles_ref.html Normal file
View file

@ -0,0 +1,11 @@
<!doctype html>
<meta charset="utf-8">
<body>
<style>
body {
color: green;
}
</style>
This text should be green and the background should not be red.
</body>