From b4b9e2c51571b4d8acdd107aa62499c73c7790cf Mon Sep 17 00:00:00 2001 From: Kenzie Raditya Tirtarahardja Date: Fri, 18 Jul 2025 14:42:51 +0800 Subject: [PATCH] Webdriver: Forward ErrorStatus for take element screenshot (#38134) Based on [spec](tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini), we should not expect the error to only be `ErrorStatus::StaleElementReference`. Testing: `tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini` Signed-off-by: PotatoCP --- components/webdriver_server/lib.rs | 5 +---- .../take_element_screenshot/screenshot.py.ini | 18 ------------------ 2 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644 tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini diff --git a/components/webdriver_server/lib.rs b/components/webdriver_server/lib.rs index 9a3b5634db9..1773236bb37 100644 --- a/components/webdriver_server/lib.rs +++ b/components/webdriver_server/lib.rs @@ -2324,10 +2324,7 @@ impl Handler { serde_json::to_value(encoded)?, ))) }, - Err(_) => Err(WebDriverError::new( - ErrorStatus::StaleElementReference, - "Element not found", - )), + Err(error) => Err(WebDriverError::new(error, "Element not found")), } } diff --git a/tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini b/tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini deleted file mode 100644 index 37cf5675d2a..00000000000 --- a/tests/wpt/meta/webdriver/tests/classic/take_element_screenshot/screenshot.py.ini +++ /dev/null @@ -1,18 +0,0 @@ -[screenshot.py] - [test_no_such_element_with_invalid_value] - expected: FAIL - - [test_no_such_element_with_shadow_root] - expected: FAIL - - [test_no_such_element_from_other_window_handle[open\]] - expected: FAIL - - [test_no_such_element_from_other_window_handle[closed\]] - expected: FAIL - - [test_no_such_element_from_other_frame[open\]] - expected: FAIL - - [test_no_such_element_from_other_frame[closed\]] - expected: FAIL