Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-29 16:19:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Handle generated content with display: block correctly during flow

Browse source 
construction.

The iteration was incorrect here. Although it accidentally worked
before, it will cause problems when we have incremental style
recalculation.

The `after_block_iteration` reftest will become interesting once we have
incremental style recalc.
This commit is contained in:
Patrick Walton 2014-09-17 18:03:24 -07:00
parent 6d6726178a
commit b4db9aeaeb
6 changed files with 86 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/ref/after_block_iteration.html Normal file
View file

@ -0,0 +1,19 @@
<!DOCTYPE html>
<html>
<head>
<!--
Although this test may seem (and is) trivial, it ensures that iteration with generated content
with `display: block` is correct during flow construction. Before this commit, this could hang
when combined with incremental reflow, since the parallel traversal counters would become
corrupted.
-->
<title>ack</title>
<style>
div.after-portlet-lang:after {
display: block;
}
</style>
<body>
<div class='after-portlet-lang'><div>x</div></div>
</body>
</html>

11
tests/ref/after_block_iteration_ref.html Normal file
View file

@ -0,0 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<title>ack</title>
<style>
</style>
<body>
<div>x</div>
</body>
</html>

1
tests/ref/basic.list
View file

@ -134,3 +134,4 @@ flaky_gpu,flaky_linux == acid2_noscroll.html acid2_ref_broken.html
== inline_block_with_margin_a.html inline_block_with_margin_ref.html
== table_padding_a.html table_padding_ref.html
== img_block_display_a.html img_block_display_ref.html
== after_block_iteration.html after_block_iteration_ref.html