Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm

Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->

etc/ci/buildbot_steps.yml

@@ -113,7 +113,9 @@ linux-nightly:
   - env CC=gcc-5 CXX=g++-5 ./mach build --release
   - ./mach package --release
   - ./mach upload-nightly linux
-  - ./mach test-perf --submit
+  - ./mach test-perf
+  - python ./etc/ci/performance/download_buildbot_timings.py --verbose
+  - aws s3 sync --size-only --acl public-read ./etc/ci/performance/output s3://servo-perf
 
 android:
   - ./mach clean-nightlies --keep 3 --force

etc/ci/performance/download_buildbot_timings.py

@@ -12,8 +12,13 @@ import json
 from math import floor
 import os
 
+SCRIPT_PATH = os.path.split(__file__)[0]
+
 
 def main():
+    default_output_dir = os.path.join(SCRIPT_PATH, 'output')
+    default_cache_dir = os.path.join(SCRIPT_PATH, '.cache')
+
     parser = argparse.ArgumentParser(
         description="Download buildbot metadata"
     )
@@ -29,9 +34,8 @@ def main():
                         "Default: http://build.servo.org/json/builders/{}/builds/{}")
     parser.add_argument("--cache-dir",
                         type=str,
-                        default='.cache',
-                        help="the directory to cache JSON files in. "
-                        "Default: .cache")
+                        default=default_cache_dir,
+                        help="the directory to cache JSON files in. Default: " + default_cache_dir)
     parser.add_argument("--cache-name",
                         type=str,
                         default='build-{}-{}.json',
@@ -39,9 +43,8 @@ def main():
                         "Default: build-{}-{}.json")
     parser.add_argument("--output-dir",
                         type=str,
-                        default='output',
-                        help="the directory to save the CSV data to. "
-                        "Default: output")
+                        default=default_output_dir,
+                        help="the directory to save the CSV data to. Default: " + default_output_dir)
     parser.add_argument("--output-name",
                         type=str,
                         default='builds-{}-{}.csv',