wpt-tests-to-run -> wpt-args and make them last so they can override already provide (#33115)

d options

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
Samson 2024-08-19 09:29:40 +02:00 committed by GitHub
parent 84b5b64424
commit b5fe99ba5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 32 additions and 31 deletions

View file

@ -8,7 +8,7 @@ on:
profile:
required: true
type: string
wpt-tests-to-run:
wpt-args:
required: true
type: string
wpt-layout:
@ -37,7 +37,7 @@ jobs:
profile: ${{ inputs.profile }}
wpt-layout: ${{ inputs.wpt-layout }}
unit-tests: ${{ inputs.unit-tests }}
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
linux:
if: ${{ inputs.workflow == 'linux' }}
@ -48,7 +48,7 @@ jobs:
profile: ${{ inputs.profile }}
wpt-layout: ${{ inputs.wpt-layout }}
unit-tests: ${{ inputs.unit-tests }}
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
android:
if: ${{ inputs.workflow == 'android' }}

View file

@ -5,7 +5,7 @@ on:
profile:
required: true
type: string
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -67,13 +67,13 @@ jobs:
python3 ./mach test-wpt \
$WPT_LAYOUT_ARG \
$WPT_ALWAYS_SUCCEED_ARG \
${{ inputs.wpt-tests-to-run }} \
--${{ inputs.profile }} --processes $(nproc) --timeout-multiplier 2 \
--total-chunks ${{ env.max_chunk_id }} --this-chunk ${{ matrix.chunk_id }} \
--log-raw wpt-full-logs/linux-${{ inputs.wpt-layout }}/raw/${{ matrix.chunk_id }}.log \
--log-wptreport wpt-full-logs/linux-${{ inputs.wpt-layout }}/wptreport/${{ matrix.chunk_id }}.json \
--log-raw-unexpected wpt-filtered-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.log \
--filter-intermittents wpt-filtered-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.json
--filter-intermittents wpt-filtered-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.json \
${{ inputs.wpt-args }}
env:
GITHUB_CONTEXT: ${{ toJson(github) }}
- name: Archive results (filtered)

View file

@ -6,7 +6,7 @@ on:
required: false
default: "release"
type: string
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -35,7 +35,7 @@ on:
default: "release"
type: choice
options: ["release", "debug", "production"]
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -161,7 +161,7 @@ jobs:
needs: ["build"]
uses: ./.github/workflows/linux-wpt.yml
with:
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
profile: ${{ inputs.profile }}
wpt-sync-from-upstream: ${{ inputs.wpt-sync-from-upstream }}
wpt-layout: "layout-2020"
@ -173,7 +173,7 @@ jobs:
needs: ["build"]
uses: ./.github/workflows/linux-wpt.yml
with:
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
profile: ${{ inputs.profile }}
wpt-sync-from-upstream: ${{ inputs.wpt-sync-from-upstream }}
wpt-layout: "layout-2013"

View file

@ -3,7 +3,7 @@ name: Mac WPT Tests
on:
workflow_call:
inputs:
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -52,12 +52,13 @@ jobs:
run: |
mkdir -p wpt-filtered-logs/macos-${{ inputs.wpt-layout }}
mkdir -p wpt-full-logs/macos-${{ inputs.wpt-layout }}
python3 ./mach test-wpt $WPT_COMMAND_LINE_ARG ${{ inputs.wpt-tests-to-run }} \
python3 ./mach test-wpt $WPT_COMMAND_LINE_ARG \
--${{ inputs.profile }} --processes $(sysctl -n hw.logicalcpu) --timeout-multiplier 8 \
--total-chunks ${{ env.max_chunk_id }} --this-chunk ${{ matrix.chunk_id }} \
--log-raw wpt-full-logs/macos-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.log \
--log-raw-unexpected wpt-filtered-logs/macos-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.log \
--filter-intermittents wpt-filtered-logs/macos-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.json
${{ inputs.wpt-args }}
- name: Archive results (filtered)
uses: actions/upload-artifact@v4
if: ${{ always() }}

View file

@ -7,7 +7,7 @@ on:
required: false
default: "release"
type: string
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -32,7 +32,7 @@ on:
default: "release"
type: choice
options: ["release", "debug", "production"]
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -158,7 +158,7 @@ jobs:
with:
profile: ${{ inputs.profile }}
wpt-layout: "layout-2020"
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
secrets: inherit
wpt-2013:
@ -169,5 +169,5 @@ jobs:
with:
profile: ${{ inputs.profile }}
wpt-layout: "layout-2013"
wpt-tests-to-run: ${{ inputs.wpt-tests-to-run }}
wpt-args: ${{ inputs.wpt-args }}
secrets: inherit

View file

@ -136,7 +136,7 @@ jobs:
wpt-layout: ${{ matrix.wpt_layout }}
profile: ${{ matrix.profile }}
unit-tests: ${{ matrix.unit_tests }}
wpt-tests-to-run: ${{ matrix.wpt_tests_to_run }}
wpt-args: ${{ matrix.wpt_args }}
results:
name: Results

View file

@ -10,7 +10,7 @@ on:
default: "release"
type: choice
options: ["release", "debug", "production"]
wpt-tests-to-run:
wpt-args:
default: ""
required: false
type: string
@ -75,7 +75,7 @@ jobs:
if (context.eventName == "workflow_dispatch") {
// WPT-related overrides only affect Linux currently, as tests don't run by default on other platforms.
configuration.matrix[0].wpt_layout = "${{ inputs.wpt-layout }}" || "none";
configuration.matrix[0].wpt_tests_to_run = "${{ inputs.wpt-tests-to-run }}" || "";
configuration.matrix[0].wpt_args = "${{ inputs.wpt-args }}" || "";
let unit_tests = Boolean(${{ inputs.unit-tests }});
let profile = '${{ inputs.profile }}';
@ -103,7 +103,7 @@ jobs:
wpt-layout: ${{ matrix.wpt_layout }}
profile: ${{ matrix.profile }}
unit-tests: ${{ matrix.unit_tests }}
wpt-tests-to-run: ${{ matrix.wpt_tests_to_run }}
wpt-args: ${{ matrix.wpt_args }}
build-result:
name: Result