diff --git a/components/style/gecko/arc_types.rs b/components/style/gecko/arc_types.rs index 66d96492bd1..0a9bf4d5ccc 100644 --- a/components/style/gecko/arc_types.rs +++ b/components/style/gecko/arc_types.rs @@ -23,12 +23,12 @@ use gecko_bindings::bindings::RawServoRuleNodeStrong; use gecko_bindings::bindings::RawServoSupportsRule; use gecko_bindings::bindings::ServoCssRules; use gecko_bindings::structs::RawServoAnimationValue; +use gecko_bindings::structs::RawServoCssUrlData; use gecko_bindings::structs::RawServoDeclarationBlock; use gecko_bindings::structs::RawServoFontFaceRule; use gecko_bindings::structs::RawServoMediaList; use gecko_bindings::structs::RawServoStyleRule; use gecko_bindings::structs::RawServoStyleSheetContents; -use gecko_bindings::structs::RawServoCssUrlData; use gecko_bindings::sugar::ownership::{HasArcFFI, HasFFI, Strong}; use media_queries::MediaList; use properties::{ComputedValues, PropertyDeclarationBlock}; diff --git a/components/style/gecko/url.rs b/components/style/gecko/url.rs index 811a0250826..64ea654ba0c 100644 --- a/components/style/gecko/url.rs +++ b/components/style/gecko/url.rs @@ -6,9 +6,9 @@ use cssparser::Parser; use gecko_bindings::bindings; -use gecko_bindings::structs::root::nsStyleImageRequest; use gecko_bindings::structs::root::mozilla::CORSMode; use gecko_bindings::structs::root::mozilla::css::URLValue; +use gecko_bindings::structs::root::nsStyleImageRequest; use gecko_bindings::sugar::ownership::{HasArcFFI, FFIArcHelpers}; use gecko_bindings::sugar::refptr::RefPtr; use malloc_size_of::{MallocSizeOf, MallocSizeOfOps}; @@ -235,7 +235,7 @@ impl ToComputedValue for SpecifiedImageUrl { fn serialize_computed_url( url_value: &URLValue, dest: &mut CssWriter, - get_url: unsafe extern "C" fn(*const URLValue, *mut nsCString) -> (), + get_url: unsafe extern "C" fn(*const URLValue, *mut nsCString), ) -> fmt::Result where W: Write, diff --git a/components/style/gecko/values.rs b/components/style/gecko/values.rs index 2a164acd4ae..4b982404809 100644 --- a/components/style/gecko/values.rs +++ b/components/style/gecko/values.rs @@ -27,9 +27,9 @@ use values::generics::{CounterStyleOrNone, NonNegative}; use values::generics::basic_shape::ShapeRadius; use values::generics::box_::Perspective; use values::generics::flex::FlexBasis; -use values::generics::length::{MaxLength, MozLength}; use values::generics::gecko::ScrollSnapPoint; use values::generics::grid::{TrackBreadth, TrackKeyword}; +use values::generics::length::{MaxLength, MozLength}; /// A trait that defines an interface to convert from and to `nsStyleCoord`s. pub trait GeckoStyleCoordConvertible: Sized { diff --git a/components/style/stylesheets/supports_rule.rs b/components/style/stylesheets/supports_rule.rs index a91a3ea3d17..06a7807e41d 100644 --- a/components/style/stylesheets/supports_rule.rs +++ b/components/style/stylesheets/supports_rule.rs @@ -11,9 +11,8 @@ use cssparser::parse_important; use malloc_size_of::{MallocSizeOfOps, MallocUnconditionalShallowSizeOf}; use parser::ParserContext; use properties::{PropertyDeclaration, PropertyId, SourcePropertyDeclaration}; -use selectors::parser::SelectorParseErrorKind; use selector_parser::{SelectorImpl, SelectorParser}; -use selectors::parser::Selector; +use selectors::parser::{Selector, SelectorParseErrorKind}; use servo_arc::Arc; use shared_lock::{DeepCloneParams, DeepCloneWithLock, Locked}; use shared_lock::{SharedRwLock, SharedRwLockReadGuard, ToCssWithGuard}; @@ -350,13 +349,14 @@ impl RawSelector { url_data: Some(context.url_data), }; + #[allow(unused_variables)] let selector = Selector::::parse(&parser, input) .map_err(|_| input.new_custom_error(()))?; #[cfg(feature = "gecko")] { - use selectors::parser::Component; use selector_parser::PseudoElement; + use selectors::parser::Component; let has_any_unknown_webkit_pseudo = selector.has_pseudo_element() && diff --git a/components/style/values/computed/angle.rs b/components/style/values/computed/angle.rs index 04a3f30362d..1c66498f7bd 100644 --- a/components/style/values/computed/angle.rs +++ b/components/style/values/computed/angle.rs @@ -5,9 +5,9 @@ //! Computed angles. use num_traits::Zero; -use std::fmt::{self, Write}; use std::{f32, f64}; use std::f64::consts::PI; +use std::fmt::{self, Write}; use std::ops::Add; use style_traits::{CssWriter, ToCss}; use values::CSSFloat; diff --git a/components/style/values/computed/length.rs b/components/style/values/computed/length.rs index 1150552201b..d32ddcfafa0 100644 --- a/components/style/values/computed/length.rs +++ b/components/style/values/computed/length.rs @@ -14,8 +14,8 @@ use super::{Context, Number, Percentage, ToComputedValue}; use values::{specified, Auto, CSSFloat, Either, Normal}; use values::animated::{Animate, Procedure, ToAnimatedValue, ToAnimatedZero}; use values::distance::{ComputeSquaredDistance, SquaredDistance}; -use values::generics::length::{MaxLength as GenericMaxLength, MozLength as GenericMozLength}; use values::generics::NonNegative; +use values::generics::length::{MaxLength as GenericMaxLength, MozLength as GenericMozLength}; use values::specified::length::{AbsoluteLength, FontBaseSize, FontRelativeLength}; use values::specified::length::ViewportPercentageLength; diff --git a/components/style/values/specified/angle.rs b/components/style/values/specified/angle.rs index f4df2a58b12..b634756d89f 100644 --- a/components/style/values/specified/angle.rs +++ b/components/style/values/specified/angle.rs @@ -6,8 +6,8 @@ use cssparser::{Parser, Token}; use parser::{Parse, ParserContext}; -use std::fmt::{self, Write}; use std::f32::consts::PI; +use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, SpecifiedValueInfo, ToCss}; use values::CSSFloat; use values::computed::{Context, ToComputedValue}; @@ -15,6 +15,7 @@ use values::computed::angle::Angle as ComputedAngle; use values::specified::calc::CalcNode; /// A specified angle dimension. +#[cfg_attr(feature = "servo", derive(Deserialize, Serialize))] #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq, PartialOrd, ToCss)] pub enum AngleDimension { /// An angle with degree unit. diff --git a/components/style/values/specified/length.rs b/components/style/values/specified/length.rs index c4ccaa5aaea..128ab9959a5 100644 --- a/components/style/values/specified/length.rs +++ b/components/style/values/specified/length.rs @@ -18,8 +18,8 @@ use style_traits::values::specified::AllowedNumericType; use super::{AllowQuirks, Number, Percentage, ToComputedValue}; use values::{Auto, CSSFloat, Either, Normal}; use values::computed::{self, CSSPixelLength, Context, ExtremumLength}; -use values::generics::length::{MaxLength as GenericMaxLength, MozLength as GenericMozLength}; use values::generics::NonNegative; +use values::generics::length::{MaxLength as GenericMaxLength, MozLength as GenericMozLength}; use values::specified::calc::CalcNode; pub use values::specified::calc::CalcLengthOrPercentage;