Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use *const AtomicUsize rather than *mut AtomicUsize in WorkQueue.

Browse source 
Atomics use internal mutability, so this *mut is at best confusing.
This commit is contained in:
Ms2ger 2016-06-19 15:45:51 +02:00
parent 2cea4187fc
commit b68043165b
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/util/workqueue.rs
View file

@ -35,7 +35,7 @@ pub struct WorkUnit<QueueData, WorkData: Send> {
/// Messages from the supervisor to the worker. /// Messages from the supervisor to the worker.
enum WorkerMsg<QueueData: 'static, WorkData: 'static + Send> { enum WorkerMsg<QueueData: 'static, WorkData: 'static + Send> {
/// Tells the worker to start work. /// Tells the worker to start work.
Start(Worker<WorkUnit<QueueData, WorkData>>, *mut AtomicUsize, *const QueueData), Start(Worker<WorkUnit<QueueData, WorkData>>, *const AtomicUsize, *const QueueData),
/// Tells the worker to stop. It can be restarted again with a `WorkerMsg::Start`. /// Tells the worker to stop. It can be restarted again with a `WorkerMsg::Start`.
Stop, Stop,
/// Tells the worker to measure the heap size of its TLS using the supplied function. /// Tells the worker to measure the heap size of its TLS using the supplied function.
@ -199,7 +199,7 @@ impl<QueueData: Sync, WorkData: Send> WorkerThread<QueueData, WorkData> {
/// A handle to the work queue that individual work units have. /// A handle to the work queue that individual work units have.
pub struct WorkerProxy<'a, QueueData: 'a, WorkData: 'a + Send> { pub struct WorkerProxy<'a, QueueData: 'a, WorkData: 'a + Send> {
worker: &'a mut Worker<WorkUnit<QueueData, WorkData>>, worker: &'a mut Worker<WorkUnit<QueueData, WorkData>>,
ref_count: *mut AtomicUsize, ref_count: *const AtomicUsize,
queue_data: &'a QueueData, queue_data: &'a QueueData,
worker_index: u8, worker_index: u8,
} }
@ -307,10 +307,10 @@ impl<QueueData: Sync, WorkData: Send> WorkQueue<QueueData, WorkData> {
/// Synchronously runs all the enqueued tasks and waits for them to complete. /// Synchronously runs all the enqueued tasks and waits for them to complete.
pub fn run(&mut self, data: &QueueData) { pub fn run(&mut self, data: &QueueData) {
// Tell the workers to start. // Tell the workers to start.
let mut work_count = AtomicUsize::new(self.work_count); let work_count = AtomicUsize::new(self.work_count);
for worker in &mut self.workers { for worker in &mut self.workers {
worker.chan.send(WorkerMsg::Start(worker.deque.take().unwrap(), worker.chan.send(WorkerMsg::Start(worker.deque.take().unwrap(),
&mut work_count, &work_count,
data)).unwrap() data)).unwrap()
} }