Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Made assertions more helpful

Browse source
This commit is contained in:
Permutator 2017-01-05 16:08:34 -08:00
parent defa7d99a6
commit b75dcc0f88
No known key found for this signature in database
GPG key ID: 62D7A8D792C3B058
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/layout/query.rs
View file

@ -544,15 +544,16 @@ impl FragmentBorderBoxIterator for ParentOffsetBorderBoxIterator {
// We haven't found the node yet, so we're still looking for its parent. // We haven't found the node yet, so we're still looking for its parent.
// Remove all nodes at this level or higher, as they can't be parents of this node. // Remove all nodes at this level or higher, as they can't be parents of this node.
self.parent_nodes.truncate(level as usize); self.parent_nodes.truncate(level as usize);
assert!(self.parent_nodes.len() == level as usize); assert_eq!(self.parent_nodes.len(), level as usize,
"Skipped at least one level in the flow tree!");
} }
if fragment.node == self.node_address { if fragment.node == self.node_address {
// Found the fragment in the flow tree that matches the // Found the fragment in the flow tree that matches the
// DOM node being looked for. // DOM node being looked for.
// If self.node_offset_box is Some, we were treating this as an inline node! assert!(self.node_offset_box.is_none(),
assert!(self.node_offset_box.is_none()); "Node was being treated as inline, but it has an associated fragment!");
self.has_processed_node = true; self.has_processed_node = true;
self.node_offset_box = Some(NodeOffsetBoxInfo { self.node_offset_box = Some(NodeOffsetBoxInfo {
@ -582,7 +583,8 @@ impl FragmentBorderBoxIterator for ParentOffsetBorderBoxIterator {
// https://github.com/servo/servo/issues/13982 will cause // https://github.com/servo/servo/issues/13982 will cause
// this assertion to fail sometimes, so it's commented out // this assertion to fail sometimes, so it's commented out
// for now. // for now.
//assert!(node.flags.contains(FIRST_FRAGMENT_OF_ELEMENT)); /*assert!(node.flags.contains(FIRST_FRAGMENT_OF_ELEMENT),
"First fragment of inline node found wasn't its first fragment!");*/
self.node_offset_box = Some(NodeOffsetBoxInfo { self.node_offset_box = Some(NodeOffsetBoxInfo {
offset: border_box.origin, offset: border_box.origin,