Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #6945 - Manishearth:fixedme, r=jdm

Browse source 
If let is not an issue for lints

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6945)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-08-04 14:38:31 -06:00
commit b7e592443f
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/plugins/lints/unrooted_must_root.rs
View file

@ -202,10 +202,12 @@ impl LintPass for UnrootedPass {
// We need not check arms individually since enum/struct fields are already // We need not check arms individually since enum/struct fields are already
// linted in `check_struct_def` and `check_variant` // linted in `check_struct_def` and `check_variant`
// (so there is no way of destructuring out a `#[must_root]` field) // (so there is no way of destructuring out a `#[must_root]` field)
ast::ExprMatch(ref e, _, _) | ast::ExprMatch(ref e, _, _) => &**e,
// For loops allow you to bind a return value locally // These are able to bind local variables, but are desugared into
ast::ExprForLoop(_, ref e, _, _) => &**e, // loops and matches pre-lint so should not be encountered
// XXXManishearth look into `if let` once it lands in our rustc ast::ExprForLoop(..) => unreachable!(),
ast::ExprIfLet(..) => unreachable!(),
ast::ExprWhileLet(..) => unreachable!(),
_ => return _ => return
}, },
_ => return _ => return