Auto merge of #27299 - avr1254:master, r=jdm

Implemented get element target algorithm

Added check for area and anchor element

Finished issue: Implemented get target and no opener algorithm

Implemented get element target and get element noopener algorithms.

<!-- Please describe your changes on the following line: -->
Used the algorithms in html spec to implement target and no opener algorithms.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #27253 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-07-24 17:30:38 -04:00 committed by GitHub
commit b83433fb14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 90 additions and 59 deletions

View file

@ -8,6 +8,9 @@
[[data-expected-height\] 3]
expected: FAIL
[[data-expected-height\] 4]
[[data-expected-height\] 1]
expected: FAIL
[[data-expected-height\] 2]
expected: FAIL

View file

@ -0,0 +1,5 @@
[opener-closed.html]
expected: TIMEOUT
[An auxiliary browsing context should report `null` for `window.opener` when that browsing context is discarded]
expected: TIMEOUT

View file

@ -0,0 +1,3 @@
[choose-_blank-003.html]
[Context created by link targeting "_blank" should retain opener reference]
expected: FAIL

View file

@ -2,21 +2,12 @@
[<form rel="opener noopener"> with <button formtarget>]
expected: FAIL
[<form rel="noopener noreferrer"> with <button formtarget>]
expected: FAIL
[<form rel=""> with <button formtarget>]
expected: FAIL
[<form rel="noreferrer opener"> with <button formtarget>]
expected: FAIL
[<form rel="noopener"> with <button formtarget>]
expected: FAIL
[<form rel="noreferrer"> with <button formtarget>]
expected: FAIL
[<form rel="opener"> with <button formtarget>]
expected: FAIL

View file

@ -1,13 +1,4 @@
[rel-form-target.html]
[<form rel="noopener noreferrer"> with <form target>]
expected: FAIL
[<form rel="noreferrer opener"> with <form target>]
expected: FAIL
[<form rel="noreferrer"> with <form target>]
expected: FAIL
[<form rel="opener noopener"> with <form target>]
expected: FAIL

View file

@ -8,15 +8,6 @@
[<form rel=""> with <input formtarget>]
expected: FAIL
[<form rel="noreferrer opener"> with <input formtarget>]
expected: FAIL
[<form rel="noopener noreferrer"> with <input formtarget>]
expected: FAIL
[<form rel="noreferrer"> with <input formtarget>]
expected: FAIL
[<form rel="noopener"> with <input formtarget>]
expected: FAIL

View file

@ -3,15 +3,9 @@
[Check that targeting of rel=noopener with a given name ignores an existing window with that name]
expected: NOTRUN
[Check that rel=noopener with target=_parent does a normal load]
expected: FAIL
[Check that targeting of rel=noopener with a given name reuses an existing window with that name]
expected: FAIL
[Check that rel=noopener with target=_top does a normal load]
expected: FAIL
[Check that rel=noopener with target=_self does a normal load]
expected: FAIL

View file

@ -9,9 +9,6 @@
[Area element with target=_blank with rel=opener]
expected: TIMEOUT
[Anchor element with target=_blank with implicit rel=noopener]
expected: FAIL
[Area element with target=_blank with implicit rel=noopener]
expected: TIMEOUT