From 7b17251cd9de73aeb7138ba23b8eec47b5b08cbb Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Fri, 20 May 2016 13:53:18 -0500 Subject: [PATCH 1/3] Hide some PR template content --- PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 50f1ee4282e..2a8025dc48e 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,10 @@ -Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: + - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors -- [ ] These changes fix #__ (github issue number if applicable). +- [ ] These changes fix #__ -Either: + - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ -Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. + From ac757b40ec7bee69fc9c25d2ae16813362c69732 Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Tue, 24 May 2016 15:27:10 -0400 Subject: [PATCH 2/3] Separate checklist from PR description. --- PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 2a8025dc48e..22c5a8765af 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,10 @@ +Replace this paragraph with a description of the changes, then follow the instructions in the next section. + +--- - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors -- [ ] These changes fix #__ +- [ ] These changes fix #__ (github issue number if applicable). - [ ] There are tests for these changes OR From 1cfc2c9104b200059f4e66d12fd17dbcc9ebf13c Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Tue, 24 May 2016 16:13:05 -0400 Subject: [PATCH 3/3] Try to mitigate the risk of unmodified PR descriptions --- PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 22c5a8765af..8434ec91eea 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -Replace this paragraph with a description of the changes, then follow the instructions in the next section. + ---