From b902e0f8f5c54614ae187e8e438d2f1dc242feb3 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Sat, 19 Jul 2014 18:02:43 +0100 Subject: [PATCH] Remove UrlMap, just use HashMap --- src/components/net/image_cache_task.rs | 10 +++++----- src/components/net/local_image_cache.rs | 6 +++--- src/components/util/url.rs | 8 -------- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/components/net/image_cache_task.rs b/src/components/net/image_cache_task.rs index 75e51bbea9e..6bd719f316c 100644 --- a/src/components/net/image_cache_task.rs +++ b/src/components/net/image_cache_task.rs @@ -5,9 +5,9 @@ use image::base::{Image, load_from_memory}; use resource_task; use resource_task::{LoadData, ResourceTask}; -use servo_util::url::{UrlMap, url_map}; use std::comm::{channel, Receiver, Sender}; +use std::collections::hashmap::HashMap; use std::mem::replace; use std::task::spawn; use std::result; @@ -88,8 +88,8 @@ impl ImageCacheTask { resource_task: resource_task.clone(), port: port, chan: chan_clone, - state_map: url_map(), - wait_map: url_map(), + state_map: HashMap::new(), + wait_map: HashMap::new(), need_exit: None }; cache.run(); @@ -136,9 +136,9 @@ struct ImageCache { /// A copy of the shared chan to give to child tasks chan: Sender, /// The state of processsing an image for a URL - state_map: UrlMap, + state_map: HashMap, /// List of clients waiting on a WaitForImage response - wait_map: UrlMap>>>>, + wait_map: HashMap>>>>, need_exit: Option>, } diff --git a/src/components/net/local_image_cache.rs b/src/components/net/local_image_cache.rs index 7f35ebd2683..1427c831654 100644 --- a/src/components/net/local_image_cache.rs +++ b/src/components/net/local_image_cache.rs @@ -12,7 +12,7 @@ use image_cache_task::{Decode, GetImage, ImageCacheTask, ImageFailed, ImageNotRe use image_cache_task::{ImageResponseMsg, Prefetch, WaitForImage}; use std::comm::{Receiver, channel}; -use servo_util::url::{UrlMap, url_map}; +use std::collections::hashmap::HashMap; use servo_util::task::spawn_named; use url::Url; @@ -24,7 +24,7 @@ pub struct LocalImageCache { image_cache_task: ImageCacheTask, round_number: uint, on_image_available: Option>, - state_map: UrlMap + state_map: HashMap } impl LocalImageCache { @@ -33,7 +33,7 @@ impl LocalImageCache { image_cache_task: image_cache_task, round_number: 1, on_image_available: None, - state_map: url_map() + state_map: HashMap::new() } } } diff --git a/src/components/util/url.rs b/src/components/util/url.rs index 7e153b3257c..9778abd5f83 100644 --- a/src/components/util/url.rs +++ b/src/components/util/url.rs @@ -2,7 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use std::collections::hashmap::HashMap; use rust_url; use rust_url::{Url, UrlParser}; @@ -31,13 +30,6 @@ pub fn parse_url(str_url: &str, base_url: Option) -> rust_url::Ur } -pub type UrlMap = HashMap; - -pub fn url_map() -> UrlMap { - HashMap::new() -} - - pub fn is_image_data(uri: &str) -> bool { static types: &'static [&'static str] = &["data:image/png", "data:image/gif", "data:image/jpeg"]; types.iter().any(|&type_| uri.starts_with(type_))