Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Disable NSCAP_FEATURE_USE_BASE

Browse source 
This is a relatively small code size regression (130k on windows and
macOS, 180k on Linux), for a few high confidence improvements in
speedometer 3. See link in the bug.

If this sticks, we can actually clean up a bunch of code, and eventually
unify RefPtr and nsCOMPtr. But I want this to be on the tree for a while
before doing more aggressive refactorings / actually removing the code.

Differential Revision: https://phabricator.services.mozilla.com/D178267
This commit is contained in:
Emilio Cobos Álvarez 2023-05-17 16:59:24 +00:00 • committed by Martin Robinson
parent 7a2b444a60
commit b92440ef7c
4 changed files with 7 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/style/gecko/media_queries.rs
View file

@ -74,7 +74,7 @@ impl fmt::Debug for Device {
let mut doc_uri = nsCString::new();
unsafe {
bindings::Gecko_nsIURI_Debug(
(*self.document()).mDocumentURI.raw::<structs::nsIURI>(),
(*self.document()).mDocumentURI.raw(),
&mut doc_uri,
)
};

6
components/style/gecko/wrapper.rs
View file

@ -413,7 +413,7 @@ impl<'ln> TNode for GeckoNode<'ln> {
unsafe {
self.0
.mFirstChild
.raw::<nsIContent>()
.raw()
.as_ref()
.map(GeckoNode::from_content)
}
@ -428,7 +428,7 @@ impl<'ln> TNode for GeckoNode<'ln> {
fn prev_sibling(&self) -> Option<Self> {
unsafe {
let prev_or_last = GeckoNode::from_content(self.0.mPreviousOrLastSibling.as_ref()?);
if prev_or_last.0.mNextSibling.raw::<nsIContent>().is_null() {
if prev_or_last.0.mNextSibling.raw().is_null() {
return None;
}
Some(prev_or_last)
@ -440,7 +440,7 @@ impl<'ln> TNode for GeckoNode<'ln> {
unsafe {
self.0
.mNextSibling
.raw::<nsIContent>()
.raw()
.as_ref()
.map(GeckoNode::from_content)
}