Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 08:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25634 - pshaughn:cjkcookies, r=jdm

Browse source 
Accept UTF8 cookie header values

<!-- Please describe your changes on the following line: -->
HeaderValue::to_str only works on ASCII; cookies can be utf8 too, so we decode accordingly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25608

- [ ] There are tests for these changes in http_loader; I don't know whether websocket cookies have tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-01-29 20:35:47 -05:00 • committed by GitHub
commit b939b3806f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/wpt/metadata/cookies/http-state/charset-tests.html.ini
View file

@ -1,13 +0,0 @@
[charset-tests.html]
[charset0002 - charset0002]
expected: FAIL
[charset0003 - charset0003]
expected: FAIL
[charset0004 - charset0004]
expected: FAIL
[charset0001 - charset0001]
expected: FAIL