Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

auto merge of #3934 : guillaumebort/servo/fix/84, r=jdm

Browse source 
Actually `<img>` elements in `<noscript>` are not prefetched anymore.

Probably because html5ever already parses the `<noscript>` content as raw
text data if `scripting_enabled` is activated.

See https://github.com/servo/html5ever/blob/servo/src/tree_builder/rules.rs#L126

Also, added a test to the images cache.
This commit is contained in:
bors-servo 2014-11-11 14:30:39 -07:00
commit b94f20c7c1
2 changed files with 28 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/script/dom/htmlimageelement.rs
View file

@ -60,9 +60,6 @@ impl<'a> PrivateHTMLImageElementHelpers for JSRef<'a, HTMLImageElement> {
// inform the image cache to load this, but don't store a
// handle.
//
// TODO (Issue #84): don't prefetch if we are within a
// <noscript> tag.
image_cache.send(image_cache_task::Prefetch(img_url));
}
}

28
tests/content/test_document_images_cache.html Normal file
View file

@ -0,0 +1,28 @@
<!DOCTYPE html>
<html>
<head>
<script src="harness.js"></script>
</head>
<body>
<img src="test.png">
<noscript>
<img src="test.jpg">
</noscript>
<script>
var images = document.images;
is(images, document.images);
is(images.length, 1);
var image = document.createElement("img");
image.setAttribute("src", "test.jpg");
document.body.appendChild(image);
is(images.length, 2);
document.body.removeChild(image);
is(images.length, 1);
</script>
</body>
</html>