Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

address review and disable test

Browse source
This commit is contained in:
Kunal Mohan 2020-09-23 20:30:44 +05:30
parent ef6c6a46fa
commit ba01ca1ba1
4 changed files with 9 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/gpucomputepipeline.rs
View file

@ -78,15 +78,13 @@ impl GPUComputePipelineMethods for GPUComputePipeline {
/// https://gpuweb.github.io/gpuweb/#dom-gpupipelinebase-getbindgrouplayout /// https://gpuweb.github.io/gpuweb/#dom-gpupipelinebase-getbindgrouplayout
fn GetBindGroupLayout(&self, index: u32) -> Fallible<DomRoot<GPUBindGroupLayout>> { fn GetBindGroupLayout(&self, index: u32) -> Fallible<DomRoot<GPUBindGroupLayout>> {
if index > self.bind_group_layouts.len() as u32 || if index > self.bind_group_layouts.len() as u32 {
index > self.device.limits().maxBindGroups
{
return Err(Error::Range(String::from("Index out of bounds"))); return Err(Error::Range(String::from("Index out of bounds")));
} }
return Ok(GPUBindGroupLayout::new( Ok(GPUBindGroupLayout::new(
&self.global(), &self.global(),
self.bind_group_layouts[index as usize], self.bind_group_layouts[index as usize],
None, None,
)); ))
} }
} }

8
components/script/dom/gpurenderpipeline.rs
View file

@ -78,15 +78,13 @@ impl GPURenderPipelineMethods for GPURenderPipeline {
/// https://gpuweb.github.io/gpuweb/#dom-gpupipelinebase-getbindgrouplayout /// https://gpuweb.github.io/gpuweb/#dom-gpupipelinebase-getbindgrouplayout
fn GetBindGroupLayout(&self, index: u32) -> Fallible<DomRoot<GPUBindGroupLayout>> { fn GetBindGroupLayout(&self, index: u32) -> Fallible<DomRoot<GPUBindGroupLayout>> {
if index > self.bind_group_layouts.len() as u32 || if index > self.bind_group_layouts.len() as u32 {
index > self.device.limits().maxBindGroups
{
return Err(Error::Range(String::from("Index out of bounds"))); return Err(Error::Range(String::from("Index out of bounds")));
} }
return Ok(GPUBindGroupLayout::new( Ok(GPUBindGroupLayout::new(
&self.global(), &self.global(),
self.bind_group_layouts[index as usize], self.bind_group_layouts[index as usize],
None, None,
)); ))
} }
} }

10
tests/wpt/webgpu/meta/MANIFEST.json
View file

@ -439,7 +439,7 @@
"testharness": { "testharness": {
"webgpu": { "webgpu": {
"cts.html": [ "cts.html": [
"63357f7e996ecadde32f6816dc131b94e9ab976c", "c5bc2536ab14b1174b7c01f35c85cfc6e62f5418",
[ [
"webgpu/cts.html?q=webgpu:api,operation,buffers,map_detach:*", "webgpu/cts.html?q=webgpu:api,operation,buffers,map_detach:*",
{} {}
@ -460,18 +460,10 @@
"webgpu/cts.html?q=webgpu:api,operation,command_buffer,render,basic:*", "webgpu/cts.html?q=webgpu:api,operation,command_buffer,render,basic:*",
{} {}
], ],
[
"webgpu/cts.html?q=webgpu:api,operation,copyBetweenLinearDataAndTexture:*",
{}
],
[ [
"webgpu/cts.html?q=webgpu:api,operation,fences:*", "webgpu/cts.html?q=webgpu:api,operation,fences:*",
{} {}
], ],
[
"webgpu/cts.html?q=webgpu:api,operation,render_pass,storeOp:*",
{}
],
[ [
"webgpu/cts.html?q=webgpu:api,validation,copyBufferToBuffer:*", "webgpu/cts.html?q=webgpu:api,validation,copyBufferToBuffer:*",
{} {}

4
tests/wpt/webgpu/tests/webgpu/cts.html
View file

@ -33,9 +33,9 @@
<meta name=variant content='?q=webgpu:api,operation,command_buffer,basic:*'> <meta name=variant content='?q=webgpu:api,operation,command_buffer,basic:*'>
<meta name=variant content='?q=webgpu:api,operation,command_buffer,copies:*'> <meta name=variant content='?q=webgpu:api,operation,command_buffer,copies:*'>
<meta name=variant content='?q=webgpu:api,operation,command_buffer,render,basic:*'> <meta name=variant content='?q=webgpu:api,operation,command_buffer,render,basic:*'>
<meta name=variant content='?q=webgpu:api,operation,copyBetweenLinearDataAndTexture:*'> <!--<meta name=variant content='?q=webgpu:api,operation,copyBetweenLinearDataAndTexture:*'>-->
<meta name=variant content='?q=webgpu:api,operation,fences:*'> <meta name=variant content='?q=webgpu:api,operation,fences:*'>
<meta name=variant content='?q=webgpu:api,operation,render_pass,storeOp:*'> <!--<meta name=variant content='?q=webgpu:api,operation,render_pass,storeOp:*'>-->
<!--<meta name=variant content='?q=webgpu:api,operation,resource_init,copied_texture_clear:*'>--> <!--<meta name=variant content='?q=webgpu:api,operation,resource_init,copied_texture_clear:*'>-->
<meta name=variant content='?q=webgpu:api,validation,copyBufferToBuffer:*'> <meta name=variant content='?q=webgpu:api,validation,copyBufferToBuffer:*'>
<meta name=variant content='?q=webgpu:api,validation,copy_between_linear_data_and_texture,copyBetweenLinearDataAndTexture_dataRelated:*'> <meta name=variant content='?q=webgpu:api,validation,copy_between_linear_data_and_texture,copyBetweenLinearDataAndTexture_dataRelated:*'>