Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-02 17:49:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25687 - pshaughn:taintfile, r=jdm

Browse source 
Filter file: and about: responses opaquely

<!-- Please describe your changes on the following line: -->
file: and about: schemes were being treated like data: for cors purposes, when in fact they should have been subject to opaque response filtering. A comment indicated that this was necessary for some CSS tests, but I think the comment was out of date; the only tests depending on the unfiltered responses are unit tests that do not test any CSS functionality. I've updated those tests to now test for the opaque-filtering itself.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25686

<!-- Either: -->
- [X] There are tests for these changes, but also some loss of unit test coverage (#25693) and a newly failing test case (#25692)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-02-11 13:27:14 -05:00 • committed by GitHub
commit ba23c5afee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 29 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

41
tests/wpt/metadata/fetch/api/basic/scheme-about.any.js.ini
View file

@ -1,41 +0,0 @@
[scheme-about.any.html]
type: testharness
[Fetching about:blank (GET) is OK]
expected: FAIL
[Fetching about:blank (PUT) is OK]
expected: FAIL
[Fetching about:blank (POST) is OK]
expected: FAIL
[Fetching about:blank with method GET is KO]
expected: FAIL
[Fetching about:blank with method PUT is KO]
expected: FAIL
[Fetching about:blank with method POST is KO]
expected: FAIL
[scheme-about.any.worker.html]
type: testharness
[Fetching about:blank (GET) is OK]
expected: FAIL
[Fetching about:blank (PUT) is OK]
expected: FAIL
[Fetching about:blank (POST) is OK]
expected: FAIL
[Fetching about:blank with method GET is KO]
expected: FAIL
[Fetching about:blank with method PUT is KO]
expected: FAIL
[Fetching about:blank with method POST is KO]
expected: FAIL

4
tests/wpt/metadata/workers/constructors/Worker/same-origin.html.ini
View file

@ -1,9 +1,5 @@
[same-origin.html]
type: testharness
expected: TIMEOUT
[unsupported_scheme]
expected: FAIL
[about_blank]
expected: TIMEOUT

5
tests/wpt/metadata/xhr/send-non-same-origin.htm.ini
View file

@ -1,5 +0,0 @@
[send-non-same-origin.htm]
type: testharness
[XMLHttpRequest: send() - non same-origin (about:blank)]
expected: FAIL