Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Rewrite FindEnumStringIndex to distinguish 'value not found' and 'exception raised'.

Browse source 
This is in preparation for handling those cases differently.
This commit is contained in:
Ms2ger 2014-04-18 10:09:43 +02:00
parent fa653a5984
commit baa3845362
2 changed files with 19 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/components/script/dom/bindings/codegen/CodegenRust.py
View file

@ -733,23 +733,20 @@ def getJSToNativeConversionTemplate(type, descriptorProvider, failureCode=None,
"yet") "yet")
enum = type.inner.identifier.name enum = type.inner.identifier.name
if invalidEnumValueFatal: if invalidEnumValueFatal:
handleInvalidEnumValueCode = " return 0;\n" handleInvalidEnumValueCode = "return 0;"
else: else:
handleInvalidEnumValueCode = " return 1;\n" handleInvalidEnumValueCode = "return 1;"
template = ( template = (
"{\n" "match FindEnumStringIndex(cx, ${val}, %(values)s) {\n"
#" int index = FindEnumStringIndex<%(invalidEnumValueFatal)s>(cx, ${val}, %(values)s, \"%(enumtype)s\", &ok);\n" " Err(_) => { %(handleInvalidEnumValueCode)s },\n"
" let result = FindEnumStringIndex(cx, ${val}, %(values)s);\n" " Ok(None) => { %(handleInvalidEnumValueCode)s },\n"
" if result.is_err() {\n" " Ok(Some(index)) => {\n"
"%(handleInvalidEnumValueCode)s" " //XXXjdm need some range checks up in here.\n"
" }\n" " ${declName} = cast::transmute(index);\n"
" let index = result.unwrap();\n" " },\n"
" ${declName} = cast::transmute(index); //XXXjdm need some range checks up in here\n" "}" % { "values" : enum + "Values::strings",
"}" % { "enumtype" : enum, "handleInvalidEnumValueCode" : handleInvalidEnumValueCode })
"values" : enum + "Values::strings",
"invalidEnumValueFatal" : toStringBool(invalidEnumValueFatal),
"handleInvalidEnumValueCode" : handleInvalidEnumValueCode })
if defaultValue is not None: if defaultValue is not None:
assert(defaultValue.type.tag() == IDLType.Tags.domstring) assert(defaultValue.type.tag() == IDLType.Tags.domstring)

18
src/components/script/dom/bindings/utils.rs
View file

@ -470,29 +470,25 @@ pub fn InitIds(cx: *JSContext, specs: &[JSPropertySpec], ids: &mut [jsid]) -> bo
pub fn FindEnumStringIndex(cx: *JSContext, pub fn FindEnumStringIndex(cx: *JSContext,
v: JSVal, v: JSVal,
values: &[&'static str]) -> Result<uint, ()> { values: &[&'static str]) -> Result<Option<uint>, ()> {
unsafe { unsafe {
let jsstr = JS_ValueToString(cx, v); let jsstr = JS_ValueToString(cx, v);
if jsstr.is_null() { if jsstr.is_null() {
return Err(()); return Err(());
} }
let length = 0; let length = 0;
let chars = JS_GetStringCharsAndLength(cx, jsstr, &length); let chars = JS_GetStringCharsAndLength(cx, jsstr, &length);
if chars.is_null() { if chars.is_null() {
return Err(()); return Err(());
} }
for (i, value) in values.iter().enumerate() {
let equal = value.len() == length as uint && Ok(values.iter().enumerate().find(|&(_, value)| {
value.len() == length as uint &&
range(0, length as int).all(|j| { range(0, length as int).all(|j| {
value[j] as u16 == *chars.offset(j) value[j] as u16 == *chars.offset(j)
}); })
}).map(|(i, _)| i))
if equal {
return Ok(i);
}
}
return Err(()); //XXX pass in behaviour for value not found
} }
} }