Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #7953 - frewsxcv:htmldivelement-align, r=mbrubeck

Browse source 
Implement 'align' attribute for <div> elements



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7953)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-10-10 14:11:33 -06:00
commit babeed998d
4 changed files with 10 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/htmldivelement.rs
View file

@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use dom::bindings::codegen::Bindings::HTMLDivElementBinding;
use dom::bindings::codegen::Bindings::HTMLDivElementBinding::{self, HTMLDivElementMethods};
use dom::bindings::codegen::InheritTypes::HTMLDivElementDerived;
use dom::bindings::js::Root;
use dom::document::Document;
@ -42,3 +42,11 @@ impl HTMLDivElement {
Node::reflect_node(box element, document, HTMLDivElementBinding::Wrap)
}
}
impl HTMLDivElementMethods for HTMLDivElement {
// https://html.spec.whatwg.org/multipage/#dom-div-align
make_getter!(Align);
// https://html.spec.whatwg.org/multipage/#dom-div-align
make_setter!(SetAlign, "align");
}

2
components/script/dom/webidls/HTMLDivElement.webidl
View file

@ -10,5 +10,5 @@ interface HTMLDivElement : HTMLElement {
// https://html.spec.whatwg.org/multipage/#HTMLDivElement-partial
partial interface HTMLDivElement {
// attribute DOMString align;
attribute DOMString align;
};

6
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -2451,12 +2451,6 @@
[HTMLDivElement interface: existence and properties of interface object]
expected: FAIL
[HTMLDivElement interface: attribute align]
expected: FAIL
[HTMLDivElement interface: document.createElement("div") must inherit property "align" with the proper type (0)]
expected: FAIL
[HTMLAnchorElement interface: existence and properties of interface object]
expected: FAIL

129
tests/wpt/metadata/html/dom/reflection-grouping.html.ini
View file

@ -12252,135 +12252,6 @@
[div.tabIndex: IDL set to -2147483648 followed by getAttribute()]
expected: FAIL
[div.align: typeof IDL attribute]
expected: FAIL
[div.align: IDL get with DOM attribute unset]
expected: FAIL
[div.align: setAttribute() to "" followed by IDL get]
expected: FAIL
[div.align: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL
[div.align: setAttribute() to undefined followed by IDL get]
expected: FAIL
[div.align: setAttribute() to 7 followed by IDL get]
expected: FAIL
[div.align: setAttribute() to 1.5 followed by IDL get]
expected: FAIL
[div.align: setAttribute() to true followed by IDL get]
expected: FAIL
[div.align: setAttribute() to false followed by IDL get]
expected: FAIL
[div.align: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL
[div.align: setAttribute() to NaN followed by IDL get]
expected: FAIL
[div.align: setAttribute() to Infinity followed by IDL get]
expected: FAIL
[div.align: setAttribute() to -Infinity followed by IDL get]
expected: FAIL
[div.align: setAttribute() to "\\0" followed by IDL get]
expected: FAIL
[div.align: setAttribute() to null followed by IDL get]
expected: FAIL
[div.align: setAttribute() to object "test-toString" followed by IDL get]
expected: FAIL
[div.align: setAttribute() to object "test-valueOf" followed by IDL get]
expected: FAIL
[div.align: IDL set to "" followed by getAttribute()]
expected: FAIL
[div.align: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()]
expected: FAIL
[div.align: IDL set to undefined followed by getAttribute()]
expected: FAIL
[div.align: IDL set to undefined followed by IDL get]
expected: FAIL
[div.align: IDL set to 7 followed by getAttribute()]
expected: FAIL
[div.align: IDL set to 7 followed by IDL get]
expected: FAIL
[div.align: IDL set to 1.5 followed by getAttribute()]
expected: FAIL
[div.align: IDL set to 1.5 followed by IDL get]
expected: FAIL
[div.align: IDL set to true followed by getAttribute()]
expected: FAIL
[div.align: IDL set to true followed by IDL get]
expected: FAIL
[div.align: IDL set to false followed by getAttribute()]
expected: FAIL
[div.align: IDL set to false followed by IDL get]
expected: FAIL
[div.align: IDL set to object "[object Object\]" followed by getAttribute()]
expected: FAIL
[div.align: IDL set to object "[object Object\]" followed by IDL get]
expected: FAIL
[div.align: IDL set to NaN followed by getAttribute()]
expected: FAIL
[div.align: IDL set to NaN followed by IDL get]
expected: FAIL
[div.align: IDL set to Infinity followed by getAttribute()]
expected: FAIL
[div.align: IDL set to Infinity followed by IDL get]
expected: FAIL
[div.align: IDL set to -Infinity followed by getAttribute()]
expected: FAIL
[div.align: IDL set to -Infinity followed by IDL get]
expected: FAIL
[div.align: IDL set to "\\0" followed by getAttribute()]
expected: FAIL
[div.align: IDL set to null followed by getAttribute()]
expected: FAIL
[div.align: IDL set to null followed by IDL get]
expected: FAIL
[div.align: IDL set to object "test-toString" followed by getAttribute()]
expected: FAIL
[div.align: IDL set to object "test-toString" followed by IDL get]
expected: FAIL
[div.align: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[div.itemScope: typeof IDL attribute]
expected: FAIL