Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy:Fix clippy problems in components/scripts/binding (#31893)

Browse source 
* constants have by default a static lifetime

* constants have by default a static lifetime

* unneeded unit expression

* unneeded unit expression

* Box of default value

* casting raw pointers

* casting raw pointers
This commit is contained in:
Rosemary Ajayi 2024-03-27 12:32:04 +00:00 • committed by GitHub
parent 1f31609952
commit bb7778774d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 12 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/bindings/buffer_source.rs
View file

@ -124,7 +124,7 @@ where
{
pub fn default() -> HeapBufferSource<T> {
HeapBufferSource {
buffer_source: BufferSource::Default(Box::new(Heap::default())),
buffer_source: BufferSource::Default(Box::default()),
phantom: PhantomData,
}
}

2
components/script/dom/bindings/callback.rs
View file

@ -127,7 +127,7 @@ pub trait CallbackContainer {
///
/// ["callback context"]: https://heycam.github.io/webidl/#dfn-callback-context
fn incumbent(&self) -> Option<&GlobalScope> {
self.callback_holder().incumbent.as_ref().map(Dom::deref)
self.callback_holder().incumbent.as_deref()
}
}

4
components/script/dom/bindings/conversions.rs
View file

@ -282,7 +282,7 @@ impl FromJSValConvertible for USVString {
let mut length = 0;
let chars = JS_GetTwoByteStringCharsAndLength(cx, ptr::null(), jsstr, &mut length);
assert!(!chars.is_null());
let char_vec = slice::from_raw_parts(chars as *const u16, length);
let char_vec = slice::from_raw_parts(chars, length);
Ok(ConversionResult::Success(USVString(
String::from_utf16_lossy(char_vec),
)))
@ -395,7 +395,7 @@ pub unsafe fn get_dom_class(obj: *mut JSObject) -> Result<&'static DOMClass, ()>
if is_dom_class(&*clasp) {
trace!("plain old dom object");
let domjsclass: *const DOMJSClass = clasp as *const DOMJSClass;
return Ok(&(&*domjsclass).dom_class);
return Ok(&(*domjsclass).dom_class);
}
if is_dom_proxy(obj) {
trace!("proxy dom object");