Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2993 from hazz/document-set-title

Browse source 
Correctly handle empty string on setting document.title; r=Manishearth+Ms2ger
This commit is contained in:
Ms2ger 2014-08-05 14:48:44 +02:00
commit bb7d79fe31
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/components/script/dom/document.rs
View file

@ -542,17 +542,19 @@ impl<'a> DocumentMethods for JSRef<'a, Document> {
for title_child in title_node.children() {
assert!(title_node.RemoveChild(&title_child).is_ok());
}
let new_text = self.CreateTextNode(title.clone()).root();
assert!(title_node.AppendChild(NodeCast::from_ref(&*new_text)).is_ok());
if !title.is_empty() {
let new_text = self.CreateTextNode(title.clone()).root();
assert!(title_node.AppendChild(NodeCast::from_ref(&*new_text)).is_ok());
}
},
None => {
let new_title = HTMLTitleElement::new("title".to_string(), self).root();
let new_title: &JSRef<Node> = NodeCast::from_ref(&*new_title);
let new_text = self.CreateTextNode(title.clone()).root();
assert!(new_title.AppendChild(NodeCast::from_ref(&*new_text)).is_ok());
if !title.is_empty() {
let new_text = self.CreateTextNode(title.clone()).root();
assert!(new_title.AppendChild(NodeCast::from_ref(&*new_text)).is_ok());
}
assert!(head.AppendChild(new_title).is_ok());
},
}