From 2779e0a7ed71296c3c9f6cba2038a4a506e7ade0 Mon Sep 17 00:00:00 2001 From: Philipp Hartwig Date: Sun, 31 May 2015 20:26:47 +0200 Subject: [PATCH 1/2] Restrict output of getElementsByName to HTML elements https://html.spec.whatwg.org/#dom-document-getelementsbyname --- components/script/dom/document.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index ad7af5562f9..18b50faff5d 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -1540,6 +1540,9 @@ impl<'a> DocumentMethods for JSRef<'a, Document> { Some(element) => element, None => return false, }; + if element.namespace() != &ns!(HTML) { + return false; + } element.get_attribute(&ns!(""), &atom!("name")).root().map_or(false, |attr| { // FIXME(https://github.com/rust-lang/rust/issues/23338) let attr = attr.r(); From 56a6ffd7e86f4c68da45a069416eee770f8d77a3 Mon Sep 17 00:00:00 2001 From: Philipp Hartwig Date: Mon, 1 Jun 2015 18:51:14 +0200 Subject: [PATCH 2/2] Update test expectations for getElementsByName --- .../document.getElementsByName-namespace.html.ini | 5 ----- .../document.getElementsByName-namespace.xhtml.ini | 5 ----- 2 files changed, 10 deletions(-) delete mode 100644 tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html.ini delete mode 100644 tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.xhtml.ini diff --git a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html.ini b/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html.ini deleted file mode 100644 index 75b5478bcae..00000000000 --- a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html.ini +++ /dev/null @@ -1,5 +0,0 @@ -[document.getElementsByName-namespace.html] - type: testharness - [getElementsByName and foreign namespaces] - expected: FAIL - diff --git a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.xhtml.ini b/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.xhtml.ini deleted file mode 100644 index 299bdfc1efe..00000000000 --- a/tests/wpt/metadata/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.xhtml.ini +++ /dev/null @@ -1,5 +0,0 @@ -[document.getElementsByName-namespace.xhtml] - type: testharness - [getElementsByName and foreign namespaces] - expected: FAIL -