Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-16 10:55:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Round clientTop, etc queries to pixels properly (#31187)

Browse source 
* layout: Round getClientRect queries to pixels properly

Instead of just flooring all pixels in getClientRect queries, we should
round the rectangle.

* Fix scrollWidth/scrollHeight too, and tests

* Tests passing

* Test expectation for legacy layout

---------

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Martin Robinson 2024-01-27 17:34:21 +01:00 • committed by GitHub
parent bbba839278
commit bbe505e52b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 194 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/wpt/meta/css/cssom-view/subpixel-sizes-and-offsets.tentative.html.ini Normal file
View file

@ -0,0 +1,24 @@
[subpixel-sizes-and-offsets.tentative.html]
[clientWidth, offsetWidth and scrollWidth round 5.5 to 6]
expected: FAIL
[clientWidth, offsetWidth and scrollWidth round 5.9 to 6]
expected: FAIL
[clientHeight, offsetHeight and scrollHeight round 5.1 to 5]
expected: FAIL
[clientHeight, offsetHeight and scrollHeight round 5.5 to 6]
expected: FAIL
[clientHeight, offsetHeight and scrollHeight round 5.9 to 6]
expected: FAIL
[clientLeft and clientTop don't round 44.9]
expected: FAIL
[clientLeft and clientTop don't round 44.5]
expected: FAIL
[clientLeft and clientTop don't round 44.1]
expected: FAIL

3
tests/wpt/meta/css/cssom-view/table-border-collapse-client-width-height.html.ini
View file

@ -1,3 +0,0 @@
[table-border-collapse-client-width-height.html]
[Table's clientWidth/Height and OffsetWidth/Height should be the same]
expected: FAIL

3
tests/wpt/meta/css/cssom-view/table-border-separate-client-width-height.html.ini
View file

@ -1,3 +0,0 @@
[table-border-separate-client-width-height.html]
[Table's clientWidth/Height and OffsetWidth/Height should be the same]
expected: FAIL