From 6a6b5a53ee1b9530602b4976a18a0bb1ff42e6d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 18 Nov 2017 07:04:23 +0100 Subject: [PATCH] style: Account for fallback content in GetFlattenedTreeParent. Otherwise we may inappropriately style it or what not. This asserts with the patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do StyleNewChildren (which walks over the flattened tree children). Too bad that GetXBLBinding is a virtual call in Gecko, probably can do just MAY_BE_IN_BINDING_MGR... Bug: 1418560 Reviewed-by: heycam MozReview-Commit-ID: CNU0YdKeaR0 --- components/style/gecko/wrapper.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/components/style/gecko/wrapper.rs b/components/style/gecko/wrapper.rs index d26a1d8663e..ec3d6f91968 100644 --- a/components/style/gecko/wrapper.rs +++ b/components/style/gecko/wrapper.rs @@ -227,8 +227,10 @@ impl<'ln> GeckoNode<'ln> { return false; } - if parent_el.map_or(false, |el| el.has_shadow_root()) { - return false; + if let Some(parent) = parent_el { + if parent.has_shadow_root() || parent.get_xbl_binding().is_some() { + return false; + } } true