Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add self-test and modify tidy to accomodate the test

Browse source
This commit is contained in:
Timur Borkhodoev 2018-02-01 15:57:11 -05:00
parent 41bf86631b
commit bcb4bd2f30
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
python/tidy/servo_tidy/tidy.py
View file

@ -461,8 +461,8 @@ def rec_parse(current_path, current_node):
def check_manifest_dirs(config_file, print_text=True): def check_manifest_dirs(config_file, print_text=True):
if not os.path.exists(config_file): if not os.path.exists(config_file):
print("%s manifest file is required but was not found" % config_file) yield(config_file, 0, "%s manifest file is required but was not found" % config_file)
sys.exit(1) return
# Load configs from include.ini # Load configs from include.ini
with open(config_file) as content: with open(config_file) as content:

5
python/tidy/servo_tidy_tests/test_tidy.py
View file

@ -33,6 +33,11 @@ class CheckTidiness(unittest.TestCase):
self.assertEqual("ignored directory './fake/dir' doesn't exist", errors.next()[2]) self.assertEqual("ignored directory './fake/dir' doesn't exist", errors.next()[2])
self.assertNoMoreErrors(errors) self.assertNoMoreErrors(errors)
def test_wpt_manifest_checks(self):
wrong_path = "/wrong/path.ini"
errors = tidy.check_manifest_dirs(wrong_path)
self.assertEqual("%s manifest file is required but was not found" % wrong_path, errors.next()[2])
def test_directory_checks(self): def test_directory_checks(self):
dirs = { dirs = {
os.path.join(base_path, "dir_check/webidl_plus"): ['webidl', 'test'], os.path.join(base_path, "dir_check/webidl_plus"): ['webidl', 'test'],