Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-19 11:20:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Refactor webdriver session and improve window handles (#38745)

Browse source 
This PR contains 2 parts:

1. Refactor webdriver session.
2. Improve webdriver window handles:
- Webdriver always get window handles from script thread by default.
- If script thread is blocked by user prompt, embedder stores the window
handle before user prompt appears, then webdriver can get window handle
from embedder.

Testing: Clear timeout cause by user prompt blocking script thread:
https://github.com/longvatrong111/servo/actions/runs/17033900026

---------

Signed-off-by: batu_hoang <hoang.binh.trong@huawei.com>
Signed-off-by: batu_hoang <longvatrong111@gmail.com>
Co-authored-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
batu_hoang 2025-08-22 06:46:13 +08:00 • committed by GitHub
parent b18a65ed70
commit bce9f06cf8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 372 additions and 369 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ports/servoshell/desktop/app.rs
View file

@ -382,13 +382,9 @@ impl App {
}
},
WebDriverCommandMsg::GetAllWebViews(response_sender) => {
let webviews = running_state
.webviews()
.iter()
.map(|(id, _)| *id)
.collect::<Vec<_>>();
let webviews = running_state.webviews().iter().map(|(id, _)| *id).collect();
if let Err(error) = response_sender.send(Ok(webviews)) {
if let Err(error) = response_sender.send(webviews) {
warn!("Failed to send response of GetAllWebViews: {error}");
}
},