Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use document encoding when parsing url in href setter (#33825)

Browse source 
* Implement encoding-parse-a-url algorithm

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Parse url with encoding when setting href on HtmlAnchorElement

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2024-10-13 17:12:51 +02:00 • committed by GitHub
parent 76776bf082
commit bdd5fb2e5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 46 additions and 225832 deletions
Download patch file Download diff file Expand all files Collapse all files

24
components/script/dom/htmlanchorelement.rs
View file

@ -76,15 +76,29 @@ impl HTMLAnchorElement {
)
}
// https://html.spec.whatwg.org/multipage/#concept-hyperlink-url-set
/// <https://html.spec.whatwg.org/multipage/#concept-hyperlink-url-set>
fn set_url(&self) {
// Step 1. Set this element's url to null.
*self.url.borrow_mut() = None;
// Step 2. If this element's href content attribute is absent, then return.
let attribute = self
.upcast::<Element>()
.get_attribute(&ns!(), &local_name!("href"));
*self.url.borrow_mut() = attribute.and_then(|attribute| {
let document = document_from_node(self);
document.base_url().join(&attribute.value()).ok()
});
let Some(attribute) = attribute else {
return;
};
// Step 3. Let url be the result of encoding-parsing a URL given this element's
// href content attribute's value, relative to this element's node document.
let document = document_from_node(self);
let url = document.encoding_parse_a_url(&attribute.value());
// Step 4. If url is not failure, then set this element's url to url.
if let Ok(url) = url {
*self.url.borrow_mut() = Some(url);
}
}
// https://html.spec.whatwg.org/multipage/#reinitialise-url